For vendors: Header section #504
Conversation
✅ Deploy Preview for cal-itp-mobility-marketplace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
machikoyasuda
changed the base branch from
main
to
feat/499-for-vendors-newsletter
|
There are some spacing issues here (like between paragraphs, buttons, and container alignment details), but would like to leave it to this #490 issue for a full update. Example: I COULD rewrite ALL paragraphs to have the same margin/padding-bottom, but I'd need confirmation from @segacy1 that this change is okay for ALL paragraphs across ALL the pages. Or I could write really hacky CSS that does this: The current style says that there should be |
Agree! Let's worry about all that at once. |
|
@thekaveman @angela-tran The code is ready to review. Otherwise, just awaiting a better alt image tag line. Sidenote, more on the comment above - re: #490 - I tried briefly re-writing that HTML as regular Bootstrap container/row/column code, but the mobile implementation is more complex than that because of the way the mobile switches to a Header/Illustration/Text ordering. The styles on this project in general is really tricky to refactor, in part b/c the styles were so narrowly written to fit exactly what the first design had. |
|
@machikoyasuda the png is a bit blurry, could we try it as an SVG? |
|
@machikoyasuda for alt tag, how's this: A saleswoman behind a stand for "Better Products," framed by refresh and checkmark icon illustrations. 102 characters |
|
With the inclusion of the alt tag for the illustration, this PR is now ready for review @thekaveman @angela-tran |
|
@machikoyasuda What do you think about using the SVG that Segacy uploaded in #504 (comment)? The PNG is blurry for me too |
|
The SVG is much less blurry - way better than the PNG: |
closes #495
What this PR does