fix: Issue with zoom meetings getting "invalid Meeting ID" #16669
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@askadityapandey is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
github-actions
bot
added
High priority
dosubot
bot
added
the
app-store
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (09/16/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (09/16/24)1 label was added to this PR based on Keith Williams's automation. |
Amit91848
reviewed
Sep 16, 2024
| @@ -333,12 +334,16 @@ const ZoomVideoApiAdapter = (credential: CredentialPayload): VideoApiAdapter => | |||
| body: JSON.stringify(await translateEvent(event)), | |||
| }); | |||
|
|
|||
| return Promise.resolve({ | |||
| // Fetch the updated meeting details | |||
There was a problem hiding this comment.
It is understood by the code, please remove the comment
| @@ -325,6 +325,7 @@ const ZoomVideoApiAdapter = (credential: CredentialPayload): VideoApiAdapter => | |||
| }, | |||
| updateMeeting: async (bookingRef: PartialReference, event: CalendarEvent): Promise<VideoCallData> => { | |||
| try { | |||
| // Update the meeting details | |||
anikdhabal
reviewed
Sep 16, 2024
Comment on lines
338
to
346
| const updatedMeeting = await fetchZoomApi(`meetings/${bookingRef.uid}`); | ||
| const result = zoomEventResultSchema.parse(updatedMeeting); | ||
|
|
||
| return { | ||
| type: "zoom_video", | ||
| id: bookingRef.meetingId as string, | ||
| password: bookingRef.meetingPassword as string, | ||
| url: bookingRef.meetingUrl as string, | ||
| }); | ||
| id: result.id.toString(), | ||
| password: result.password || "", | ||
| url: result.join_url, | ||
| }; |
There was a problem hiding this comment.
Changes looks good, Pls a share a loom video of the result🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?