Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Issue with zoom meetings getting "invalid Meeting ID" #16669

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Issue with zoom meetings getting "invalid Meeting ID" #16669

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9180eb9
Update VideoApiAdapter.ts
askadityapandey Sep 16, 2024
2d58f99
Update VideoApiAdapter.ts
askadityapandey Sep 16, 2024
195bdf5
Merge branch 'main' into main
Amit91848 Sep 17, 2024
68b014e
Merge branch 'main' into main
askadityapandey Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/app-store/zoomvideo/lib/VideoApiAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ const ZoomVideoApiAdapter = (credential: CredentialPayload): VideoApiAdapter =>
},
updateMeeting: async (bookingRef: PartialReference, event: CalendarEvent): Promise<VideoCallData> => {
try {
// Update the meeting details
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

await fetchZoomApi(`meetings/${bookingRef.uid}`, {
method: "PATCH",
headers: {
Expand All @@ -333,12 +334,16 @@ const ZoomVideoApiAdapter = (credential: CredentialPayload): VideoApiAdapter =>
body: JSON.stringify(await translateEvent(event)),
});

return Promise.resolve({
// Fetch the updated meeting details
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is understood by the code, please remove the comment

const updatedMeeting = await fetchZoomApi(`meetings/${bookingRef.uid}`);
const result = zoomEventResultSchema.parse(updatedMeeting);

return {
type: "zoom_video",
id: bookingRef.meetingId as string,
password: bookingRef.meetingPassword as string,
url: bookingRef.meetingUrl as string,
});
id: result.id.toString(),
password: result.password || "",
url: result.join_url,
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, Pls a share a loom video of the result🙏

} catch (err) {
log.error("Failed to update meeting", safeStringify(err));
return Promise.reject(new Error("Failed to update meeting"));
Expand Down
Loading