Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCGM snap tests #4

Merged
merged 39 commits into from
Sep 16, 2024
Merged

DCGM snap tests #4

merged 39 commits into from
Sep 16, 2024

Conversation

Deezzir
Copy link
Contributor

@Deezzir Deezzir commented Sep 6, 2024 •
edited
Loading

  • Makes and deploys dcgm-exporter as a daemon with the snap.
  • Adds tests for dcgm-exporter, dcgmi, nv-hostengine and user configs.
  • Adds the snap template files on top.

The tests are simple, and should cover the basic use cases.

@Deezzir Deezzir requested a review from a team as a code owner September 6, 2024 19:36
zxhdaze
zxhdaze reviewed Sep 6, 2024
View reviewed changes
snap/snapcraft.yaml Outdated Show resolved Hide resolved
@Deezzir Deezzir requested a review from zxhdaze September 6, 2024 20:19
aieri
aieri requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggestions

Makefile Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
tests/functional/conftest.py Show resolved Hide resolved
snap/snapcraft.yaml Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Outdated Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Outdated Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Outdated Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Outdated Show resolved Hide resolved
samuelallan72
samuelallan72 previously requested changes Sep 9, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
gabrielcocenza
gabrielcocenza requested changes Sep 9, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Outdated Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@Deezzir Deezzir mentioned this pull request Sep 10, 2024
Closed
aieri
aieri requested changes Sep 13, 2024
View reviewed changes
.github/workflows/check.yaml Show resolved Hide resolved
.github/workflows/check.yaml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
snap/hooks/configure Show resolved Hide resolved
snap/local/run_dcgm_exporter.sh Outdated Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Outdated Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Outdated Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Outdated Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@Deezzir Deezzir requested a review from aieri September 13, 2024 23:27
aieri
aieri requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! There are now only a couple of outdated comments to remove and we're good to merge.

snap/hooks/configure Outdated Show resolved Hide resolved
@Deezzir Deezzir requested a review from aieri September 13, 2024 23:54
@Deezzir
Copy link
Contributor Author

Deezzir commented Sep 13, 2024

looks good! There are now only a couple of outdated comments to remove and we're good to merge.

What comments are you referring to?

aieri
aieri previously approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me. We'll have to deal with the automation trying to overwrite check.yaml of course

@aieri
Copy link
Contributor

aieri commented Sep 14, 2024

looks good! There are now only a couple of outdated comments to remove and we're good to merge.

What comments are you referring to?

You have updated them in 4059a6d so we're fine

gabrielcocenza
gabrielcocenza reviewed Sep 16, 2024
View reviewed changes
tests/functional/conftest.py Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Outdated Show resolved Hide resolved
tests/functional/test_snap_dcgm.py Outdated Show resolved Hide resolved
@Deezzir Deezzir requested a review from aieri September 16, 2024 17:07
@Deezzir Deezzir merged commit 080ab2e into canonical:main Sep 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielcocenza gabrielcocenza gabrielcocenza approved these changes

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@aieri aieri aieri approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

@zxhdaze zxhdaze Awaiting requested review from zxhdaze

@chanchiwai-ray chanchiwai-ray Awaiting requested review from chanchiwai-ray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Deezzir @aieri @samuelallan72 @gabrielcocenza @zxhdaze @chanchiwai-ray