Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PostgreSQL integration #7

Merged
merged 10 commits into from
Sep 19, 2024
Merged

feat: add PostgreSQL integration #7

merged 10 commits into from
Sep 19, 2024

Conversation

amandahla
Copy link
Collaborator

@amandahla amandahla commented Sep 10, 2024

Applicable spec:

Overview

Maubot requires a database.

Note: This PR is a mashup of code I liked from other charms while working on PostgreSQL integration. I hope you'll find it familiar during your review.

Rationale

Add PostgreSQL integration as required.

Juju Events Changes

database-created
endpoints-changed.

Module Changes

Library Changes

Checklist

No CH available yet

@amandahla amandahla requested a review from a team as a code owner September 10, 2024 20:05
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 39 files.

Valid Invalid Ignored Fixed
12 1 26 0
Click to see the invalid file list
  • lib/charms/data_platform_libs/v0/data_interfaces.py
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

@canonical canonical deleted a comment from github-actions bot Sep 10, 2024
@amandahla amandahla changed the title feat: Add PostgreSQL integration feat: add PostgreSQL integration Sep 11, 2024
Copy link

@javierdelapuente javierdelapuente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. A few comments.

src/charm.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
tests/unit/test_charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@amandahla amandahla mentioned this pull request Sep 13, 2024
6 tasks
Copy link

Test coverage for de0dda3

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      74      6      8      1    91%   81-82, 109, 113, 122, 144
----------------------------------------------------------
TOTAL             74      6      8      1    91%

Static code analysis report

Run started:2024-09-17 17:17:04.557794

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 272
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@Thanhphan1147
Copy link

LGTM, some minor comments

@amandahla amandahla merged commit 3f09911 into main Sep 19, 2024
17 checks passed
@amandahla amandahla deleted the ISD-2273-postgresql branch September 19, 2024 17:33
@amandahla amandahla mentioned this pull request Sep 19, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants