-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add PostgreSQL integration #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 39 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
12 | 1 | 26 | 0 |
Click to see the invalid file list
- lib/charms/data_platform_libs/v0/data_interfaces.py
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. A few comments.
Test coverage for de0dda3
Static code analysis report
|
LGTM, some minor comments |
Applicable spec:
Overview
Maubot requires a database.
Note: This PR is a mashup of code I liked from other charms while working on PostgreSQL integration. I hope you'll find it familiar during your review.
Rationale
Add PostgreSQL integration as required.
Juju Events Changes
database-created
endpoints-changed.
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)No CH available yet