Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshots] Delete snapshot cli and daemon placeholder #3092

Merged
merged 5 commits into from
Jun 27, 2023

[cli] edit user strings and optimize loops

08ee002
Select commit
Loading
Failed to load commit list.
Merged

[snapshots] Delete snapshot cli and daemon placeholder #3092

[cli] edit user strings and optimize loops
08ee002
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Jun 23, 2023 in 0s

84.84% (+0.12%) compared to 278bea7

View this Pull Request on Codecov

84.84% (+0.12%) compared to 278bea7

Details

Codecov Report

Merging #3092 (08ee002) into snapshots (278bea7) will increase coverage by 0.12%.
The diff coverage is 61.27%.

@@              Coverage Diff              @@
##           snapshots    #3092      +/-   ##
=============================================
+ Coverage      84.71%   84.84%   +0.12%     
=============================================
  Files            241      246       +5     
  Lines          12765    13035     +270     
=============================================
+ Hits           10814    11059     +245     
- Misses          1951     1976      +25     
Impacted Files Coverage Δ
include/multipass/alias_definition.h 100.00% <ø> (ø)
include/multipass/exceptions/snapshot_name_taken.h 0.00% <0.00%> (ø)
include/multipass/id_mappings.h 100.00% <ø> (ø)
include/multipass/virtual_machine.h 100.00% <ø> (ø)
src/client/cli/cmd/unalias.h 100.00% <ø> (ø)
src/daemon/daemon.h 100.00% <ø> (ø)
src/daemon/daemon_config.cpp 64.13% <0.00%> (-1.43%) ⬇️
src/daemon/daemon_rpc.cpp 87.87% <0.00%> (ø)
src/daemon/default_vm_image_vault.cpp 86.14% <ø> (ø)
...tform/backends/libvirt/libvirt_virtual_machine.cpp 62.88% <0.00%> (ø)
... and 50 more