[daemon] Remove hyperkit migration support #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3123 +/- ##
==========================================
+ Coverage 87.50% 88.62% +1.11%
==========================================
Files 238 238
Lines 12351 12145 -206
==========================================
- Hits 10808 10763 -45
+ Misses 1543 1382 -161
|
andrei-toterman
requested changes
Jun 16, 2023
There was a problem hiding this comment.
Hi, @townsend2010! I ran rg 'hyperkit|\shk\s' -i and found the following
src/daemon/CMakeLists.txt: scope_guard # TODO hk migration, remove
src/daemon/daemon.cpp:#include <multipass/cloud_init_iso.h> // TODO hk migration, remove
src/daemon/daemon.cpp:#include <multipass/file_ops.h> // TODO hk migration, remove
src/daemon/daemon.cpp:#include <multipass/process/qemuimg_process_spec.h> // TODO hk migration, remove
src/daemon/daemon.cpp:#include <multipass/process/simple_process_spec.h> // TODO hk migration, remove
src/daemon/daemon.cpp:#include <multipass/standard_paths.h> // TODO hk migration, remove
src/daemon/daemon.cpp:#include <scope_guard.hpp> // TODO hk migration, remove
src/daemon/daemon.cpp:#include <cerrno> // TODO hk migration, remove
src/daemon/daemon.cpp:#include <cstring> // TODO hk migration, remove
src/daemon/daemon.cpp:#include <iterator> // TODO hk migration, remove
README.md:KVM on Linux, Hyper-V on Windows and HyperKit on macOS to run the VM with minimal
tests/test_daemon_find.cpp: EXPECT_CALL(mock_settings, get(Eq(mp::driver_key))).WillRepeatedly(Return("nohk")); // TODO hk migration, remove
tests/test_daemon_launch.cpp: EXPECT_CALL(mock_settings, get(Eq(mp::driver_key))).WillRepeatedly(Return("nohk")); // TODO hk migration, remove
tests/test_daemon.cpp: EXPECT_CALL(mock_settings, get(Eq(mp::driver_key))).WillRepeatedly(Return("nohk")); // TODO hk migration, remove
tests/test_daemon_start.cpp: EXPECT_CALL(mock_settings, get(Eq(mp::driver_key))).WillRepeatedly(Return("nohk")); // TODO hk migration, remove
and I assume those should be removed in this PR as well :)
townsend2010
force-pushed
the
remove-hyperkit-support
branch
from
b9a0d16
to
253159f
Compare
added 5 commits
June 21, 2023 13:42
Hyperkit is being removed from Multipass.
Since Hyperkit is being removed, there is no need to download the separate initrd and kernel and keeping track of them.
townsend2010
force-pushed
the
remove-hyperkit-support
branch
from
253159f
to
cad451d
Compare
andrei-toterman
approved these changes
Jun 23, 2023
bors bot
added a commit
that referenced
this pull request
Jun 23, 2023
3123: [daemon] Remove hyperkit migration support r=andrei-toterman a=townsend2010 Co-authored-by: Chris Townsend <[email protected]>
|
|
|
This PR was included in a batch that successfully built, but then failed to merge into main (it was a non-fast-forward update). It will be automatically retried. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.