Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[daemon] Remove hyperkit migration support #3123

Merged
merged 5 commits into from
Jun 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions 3rd-party/submodule_info.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,6 @@ Version: 1.9.4 |
<https://github.com/open-source-parsers/jsoncpp.git> |
<https://github.com/open-source-parsers/jsoncpp/releases>

### HyperKit
Version: v0.20210107 |
<https://github.com/moby/hyperkit.git> |
<https://github.com/moby/hyperkit/releases>

### POCO
Version: 1.12.4 |
<https://github.com/pocoproject/poco.git> |
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Multipass is a lightweight VM manager for Linux, Windows and macOS. It's designed
for developers who want a fresh Ubuntu environment with a single command. It uses
KVM on Linux, Hyper-V on Windows and HyperKit on macOS to run the VM with minimal
KVM on Linux, Hyper-V on Windows and QEMU on macOS to run the VM with minimal
overhead. It can also use VirtualBox on Windows and macOS.
Multipass will fetch images for you and keep them up to date.

Expand Down
3 changes: 1 addition & 2 deletions include/multipass/fetch_type.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ namespace multipass
{
enum class FetchType
{
ImageOnly,
ImageKernelAndInitrd
ImageOnly
};
}
#endif //MULTIPASS_FETCH_TYPE_H
2 changes: 0 additions & 2 deletions include/multipass/vm_image.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ class VMImage
{
public:
Path image_path;
Path kernel_path;
Path initrd_path;
std::string id;
std::string original_release;
std::string current_release;
Expand Down
10 changes: 4 additions & 6 deletions include/multipass/vm_image_info.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ class VMImageInfo
QString release_title;
bool supported;
QString image_location;
QString kernel_location;
QString initrd_location;
QString id;
QString stream_location;
QString version;
Expand All @@ -43,10 +41,10 @@ class VMImageInfo

inline bool operator==(const VMImageInfo& a, const VMImageInfo& b)
{
return std::tie(a.aliases, a.os, a.release, a.release_title, a.supported, a.image_location, a.kernel_location,
a.initrd_location, a.id, a.stream_location, a.version, a.size, a.verify) ==
std::tie(b.aliases, b.os, b.release, b.release_title, b.supported, b.image_location, b.kernel_location,
b.initrd_location, b.id, b.stream_location, b.version, b.size, b.verify);
return std::tie(a.aliases, a.os, a.release, a.release_title, a.supported, a.image_location, a.id, a.stream_location,
a.version, a.size, a.verify) == std::tie(b.aliases, b.os, b.release, b.release_title, b.supported,
b.image_location, b.id, b.stream_location, b.version,
b.size, b.verify);
}
}
#endif // MULTIPASS_VM_IMAGE_INFO_H
2 changes: 0 additions & 2 deletions src/client/cli/cmd/launch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -564,8 +564,6 @@ mp::ReturnCode cmd::Launch::request_launch(const ArgParser* parser)
grpc::ClientReaderWriterInterface<LaunchRequest, LaunchReply>* client) {
std::unordered_map<int, std::string> progress_messages{
{LaunchProgress_ProgressTypes_IMAGE, "Retrieving image: "},
{LaunchProgress_ProgressTypes_KERNEL, "Retrieving kernel image: "},
{LaunchProgress_ProgressTypes_INITRD, "Retrieving initrd image: "},
{LaunchProgress_ProgressTypes_EXTRACT, "Extracting image: "},
{LaunchProgress_ProgressTypes_VERIFY, "Verifying image: "},
{LaunchProgress_ProgressTypes_WAITING, "Preparing image: "}};
Expand Down
1 change: 0 additions & 1 deletion src/daemon/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ target_link_libraries(daemon
petname
platform
rpc
scope_guard # TODO hk migration, remove
settings
simplestreams
ssh
Expand Down
32 changes: 4 additions & 28 deletions src/daemon/custom_image_host.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ struct CustomImageInfo
QString os;
QString release;
QString release_string;
QString kernel_location;
QString initrd_location;
};

const QMap<QString, QMap<QString, CustomImageInfo>> multipass_image_info{
Expand All @@ -61,33 +59,13 @@ const QMap<QString, QMap<QString, CustomImageInfo>> multipass_image_info{
{"core", "core16"},
"Ubuntu",
"core-16",
"Core 16",
"",
""}},
"Core 16"}},
{{"ubuntu-core-18-amd64.img.xz"},
{"https://cdimage.ubuntu.com/ubuntu-core/18/stable/current/",
{"core18"},
"Ubuntu",
"core-18",
"Core 18",
"",
""}},
{"https://cdimage.ubuntu.com/ubuntu-core/18/stable/current/", {"core18"}, "Ubuntu", "core-18", "Core 18"}},
{{"ubuntu-core-20-amd64.img.xz"},
{"https://cdimage.ubuntu.com/ubuntu-core/20/stable/current/",
{"core20"},
"Ubuntu",
"core-20",
"Core 20",
"",
""}},
{"https://cdimage.ubuntu.com/ubuntu-core/20/stable/current/", {"core20"}, "Ubuntu", "core-20", "Core 20"}},
{{"ubuntu-core-22-amd64.img.xz"},
{"https://cdimage.ubuntu.com/ubuntu-core/22/stable/current/",
{"core22"},
"Ubuntu",
"core-22",
"Core 22",
"",
""}}}}};
{"https://cdimage.ubuntu.com/ubuntu-core/22/stable/current/", {"core22"}, "Ubuntu", "core-22", "Core 22"}}}}};

auto base_image_info_for(mp::URLDownloader* url_downloader, const QString& image_url, const QString& hash_url,
const QString& image_file)
Expand Down Expand Up @@ -140,8 +118,6 @@ auto full_image_info_for(const QMap<QString, CustomImageInfo>& custom_image_info
image_info.second.release_string,
true, // supported
image_url, // image_location
image_info.second.kernel_location,
image_info.second.initrd_location,
base_image_info.hash, // id
"",
base_image_info.last_modified, // version
Expand Down
Loading