-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upstream generic pagination component for tables [WD-4258] #1013
Merged
mas-who
merged 1 commit into
canonical:main
from
mas-who:upstream-table-pagination-component
Jan 19, 2024
Merged
feat: upstream generic pagination component for tables [WD-4258] #1013
mas-who
merged 1 commit into
canonical:main
from
mas-who:upstream-table-pagination-component
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo starting at https://react-components-1013.demos.haus |
mas-who
force-pushed
the
upstream-table-pagination-component
branch
8 times, most recently
from
January 12, 2024 17:31
d3a97a9
to
652fced
Compare
mas-who
added
Review: Code +1
Review: QA +1
Review: Code needed
Review: QA needed
and removed
Don't merge
Review: Code +1
Review: QA +1
labels
Jan 15, 2024
mas-who
force-pushed
the
upstream-table-pagination-component
branch
6 times, most recently
from
January 16, 2024 07:42
4e0c513
to
6495cfb
Compare
edlerd
reviewed
Jan 16, 2024
mas-who
force-pushed
the
upstream-table-pagination-component
branch
from
January 16, 2024 08:46
6495cfb
to
71613e4
Compare
Signed-off-by: Mason Hu <[email protected]>
mas-who
force-pushed
the
upstream-table-pagination-component
branch
from
January 16, 2024 12:16
71613e4
to
276a55d
Compare
mas-who
changed the title
feat: upstream generic pagination component for tables [WIP]
feat: upstream generic pagination component for tables [WD-4258]
Jan 16, 2024
edlerd
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
edlerd
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps