Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upstream generic pagination component for tables [WD-4258] #1013

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Jan 10, 2024

Done

  • upstream the pagination component used for all tables from the lxd-ui project.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

@webteam-app
Copy link

Demo starting at https://react-components-1013.demos.haus

@mas-who mas-who force-pushed the upstream-table-pagination-component branch 8 times, most recently from d3a97a9 to 652fced Compare January 12, 2024 17:31
@mas-who mas-who marked this pull request as ready for review January 12, 2024 19:39
@mas-who mas-who force-pushed the upstream-table-pagination-component branch 6 times, most recently from 4e0c513 to 6495cfb Compare January 16, 2024 07:42
@mas-who mas-who force-pushed the upstream-table-pagination-component branch from 6495cfb to 71613e4 Compare January 16, 2024 08:46
@mas-who mas-who force-pushed the upstream-table-pagination-component branch from 71613e4 to 276a55d Compare January 16, 2024 12:16
@mas-who mas-who changed the title feat: upstream generic pagination component for tables [WIP] feat: upstream generic pagination component for tables [WD-4258] Jan 16, 2024
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mas-who mas-who merged commit 0e463ac into canonical:main Jan 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants