-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Quote Wrapper Pattern #5275
Conversation
955cb4e
to
28014d3
Compare
aeeb278
to
fef001b
Compare
fef001b
to
aa0f4e2
Compare
0ff810b
to
cb2d5c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
templates/docs/examples/patterns/quote-wrapper/h2-no-citation.html
Outdated
Show resolved
Hide resolved
@pastelcyborg Good catch, I think I've fixed that by moving the highlighted rule to outside of the grid, so it covers the full width of the whole pattern |
b6756c3
to
9cf0d37
Compare
672f139
to
04c7128
Compare
Made some changes after meeting with @lyubomir-popov to discuss c.com PR 1380.
|
e4b2da7
to
aee5372
Compare
d85a05b
to
fe483ee
Compare
fe483ee
to
a4df366
Compare
I guess it could be worth updating the pattern to use new 8 col grid? But also, doesn't need to be in scope of this PR. We could address it as follow up (could be done for all patterns I suppose). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We could consider updating this (and other?) patterns to new grid, but this can be a follow up.
Done
Fixes WD-13881
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots