Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine-tuning implementation #32

Merged
merged 29 commits into from
Oct 27, 2023
Merged

Fine-tuning implementation #32

merged 29 commits into from
Oct 27, 2023

Conversation

danjoa
Copy link
Contributor

@danjoa danjoa commented Oct 25, 2023 •
edited
Loading

  • Consistent subclassing and extension API using CAP event handlers as usual:
    • Subclasses simply register handlers for 'notification' events
    • Applications can add own before / after handlers
  • Avoid overly fragmented implementations → see notifyToRest.js
  • Avoid proliferation of utils → deleted doesNotExist()
  • Console output is coloured now
  • Added default config → this is important for release / TechEd
  • Outbox always true by default, also for console (→ same as in audit-log)

@danjoa danjoa enabled auto-merge October 25, 2023 15:09
sjvans
sjvans reviewed Oct 26, 2023
View reviewed changes
srv/notifyToConsole.js Outdated Show resolved Hide resolved
sjvans
sjvans reviewed Oct 26, 2023
View reviewed changes
srv/notifyToConsole.js Outdated Show resolved Hide resolved
simeonPetkov96
simeonPetkov96 previously requested changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@simeonPetkov96 simeonPetkov96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voter fails. Please make sure all tests are successful before merge

test/lib/notificationTypes.test.js Show resolved Hide resolved
package.json Show resolved Hide resolved
sjvans
sjvans reviewed Oct 26, 2023
View reviewed changes
srv/service.js Outdated Show resolved Hide resolved
@danjoa
Copy link
Contributor Author

danjoa commented Oct 26, 2023

Fixed the tests with fe2b57b → ready to be merged from my angle now

ipaunov
ipaunov reviewed Oct 27, 2023
View reviewed changes
lib/utils.js Outdated Show resolved Hide resolved
ipaunov
ipaunov reviewed Oct 27, 2023
View reviewed changes
lib/utils.js Outdated Show resolved Hide resolved
@ipaunov ipaunov self-requested a review October 27, 2023 12:29
ipaunov
ipaunov reviewed Oct 27, 2023
View reviewed changes
test/lib/content-deployment.test.js Outdated Show resolved Hide resolved
test/lib/content-deployment.test.js Outdated Show resolved Hide resolved
test/lib/utils.test.js Outdated Show resolved Hide resolved
test/srv/notifyToRest.test.js Outdated Show resolved Hide resolved
ipaunov
ipaunov reviewed Oct 27, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ipaunov ipaunov self-requested a review October 27, 2023 13:33
ipaunov
ipaunov approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@ipaunov ipaunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@danjoa danjoa merged commit 4045d06 into main Oct 27, 2023
2 checks passed
@danjoa danjoa deleted the fine-tuning branch October 27, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjvans sjvans sjvans left review comments

@ipaunov ipaunov ipaunov approved these changes

@sidakphull sidakphull Awaiting requested review from sidakphull

@DanSchlachter DanSchlachter Awaiting requested review from DanSchlachter

@simeonPetkov96 simeonPetkov96 Awaiting requested review from simeonPetkov96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danjoa @simeonPetkov96 @sjvans @ipaunov @AnmolBinani @RamIndia