Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine-tuning implementation #32

Merged
merged 29 commits into from
Oct 27, 2023
Merged

Fine-tuning implementation #32

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6a30663
Fine-tuning implementation
danjoa Oct 25, 2023
780f771
.
danjoa Oct 25, 2023
ff9599d
Adding default config
danjoa Oct 25, 2023
f1ff170
.
danjoa Oct 25, 2023
7a34b5e
cosmetics
danjoa Oct 25, 2023
ab7bb8f
Fixed cds.requires.notifications default config
danjoa Oct 25, 2023
193e990
Adding simple API support for .data
danjoa Oct 26, 2023
e948203
Merge branch 'main' into fine-tuning
AnmolBinani Oct 26, 2023
3fccd11
Update srv/service.js
danjoa Oct 26, 2023
d81bcfd
Notify to console using console.log()
danjoa Oct 26, 2023
f87bf16
Moving templates to srv/notifications.json
danjoa Oct 26, 2023
ec97be4
srv/notification-types.json
danjoa Oct 26, 2023
fe2b57b
Fixing tests -> less mocking
danjoa Oct 26, 2023
1ffa3d9
Fixed API: just allow mixing simple and low-level APIs
danjoa Oct 26, 2023
770e07b
Filling in Language and Type of Properties
danjoa Oct 27, 2023
a1b0931
cosmetics
danjoa Oct 27, 2023
0e557e6
resolving the default prefix
RamIndia Oct 27, 2023
601100a
API variant this.notify/emit with event = type
danjoa Oct 27, 2023
6720566
updating readme
RamIndia Oct 27, 2023
f4ba4ca
readme
danjoa Oct 27, 2023
6cb38dc
Fixed resolving $app-name
danjoa Oct 27, 2023
7dd6644
More cosmetics
danjoa Oct 27, 2023
56b6d62
Updating Readme
RamIndia Oct 27, 2023
6b477ac
Fixing the test cases
RamIndia Oct 27, 2023
36c3496
Removing the redundant testcase
RamIndia Oct 27, 2023
725638b
removing id
RamIndia Oct 27, 2023
f8fd7a4
updating readme
RamIndia Oct 27, 2023
582f9e2
fix some small issues
ipaunov Oct 27, 2023
ca4c8a7
Update README.md
ipaunov Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,14 +161,14 @@ function buildCustomNotification(_) {

// Properties with simple API variants
NotificationTypeKey: getNotificationTypesKeyWithPrefix(_.NotificationTypeKey || _.type),
Recipients: _.Recipients || _.recipients?.map((recipient) => ({ RecipientId: recipient })),
Recipients: _.Recipients || _.recipients?.map(id => ({ RecipientId: id })),
Priority: _.Priority || _.priority || "NEUTRAL",
Id: _.Id || _.id,
Properties: _.Properties || _.properties || Object.entries(_.data).map(([k,v]) => ({
Properties: _.Properties || Object.entries(_.data).map(([k,v]) => ({
Key:k, Value:v, Language: "en", Type: typeof v, // IsSensitive: false
})),

// Low-level API properties
Id: _.Id,
RamIndia marked this conversation as resolved.
Show resolved Hide resolved
OriginId: _.OriginId,
NotificationTypeId: _.NotificationTypeId,
NotificationTypeVersion: _.NotificationTypeVersion || "1",
Expand Down