ASWebAuthenticationSession Support #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narcis-ro
reviewed
Mar 15, 2023
| // if the user touches "done" in safari without entering the credentials the USER_CANCELLED error is sent #71 | ||
| urlHandler.delegate = self.oauth2SafariDelegate | ||
| let urlHandler = ASWebAuthenticationURLHandler( | ||
| callbackUrlScheme: redirectUrl.replacingOccurrences(of: "://oauth", with: ""), |
There was a problem hiding this comment.
Should this be?
callbackUrlScheme: URL(string: redirectUrl)!.scheme!,
So it works with any host url? e.g ://auth
There was a problem hiding this comment.
Yes, it should be as you've written. I've not tested it with other host urls but it should with any url.
|
This PR looks like its gone a little bit quiet. I would love to see this one brought up to date and completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched the authentication method from SafariURLHandler to ASWebAuthenticationURLHandler.
Implemented ASWebAuthenticationPresentationContextProviding in the OAuth2ClientPlugin class.