Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure proper namespace for title attr #3079

Merged
merged 2 commits into from
Nov 29, 2024
Merged

fix: ensure proper namespace for title attr #3079

merged 2 commits into from
Nov 29, 2024

Conversation

nizamial09
Copy link
Contributor

@nizamial09 nizamial09 commented Nov 29, 2024 •
edited
Loading

Browsers may not always render the <title> inside SVG as a tooltip. Ensuring it has a correct namespace improves the cross browser behavior

Closes #3078

Changelog

Changed

  • added proper namespace for title attribute

@nizamial09
fix 3078: ensure proper namespace for title attr
cfeae67 
Browsers may not always render the <title> inside SVG as a tooltip.
Ensuring it has a correct namespace improves the cross browser behavior

Closes carbon-design-system#3078

Signed-off-by: Nizamudeen A <[email protected]>
@nizamial09 nizamial09 requested a review from a team as a code owner November 29, 2024 04:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2024 •
edited
Loading

✅ Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 72ec078
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/674a4420d233b700089ee8e1
😎 Deploy Preview https://deploy-preview-3079--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nizamial09
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@nizamial09
Copy link
Contributor Author

I saw these errors when I ran npm run lint

src/combobox/combobox.component.spec.ts:36:9
ERROR: 36:9    quotemark       ' should be "
ERROR: 210:34  quotemark       ' should be "

src/combobox/combobox.component.ts:699:1
ERROR: 699:1   indent          tab indentation expected
ERROR: 700:1   indent          tab indentation expected
ERROR: 701:1   indent          tab indentation expected
ERROR: 702:1   indent          tab indentation expected
ERROR: 703:1   indent          tab indentation expected
ERROR: 704:1   indent          tab indentation expected

src/datepicker/datepicker.stories.ts:171:32
ERROR: 171:32  trailing-comma  Unnecessary trailing comma

Unrelated to my PR though

@Akshat55
Copy link
Contributor

I saw these errors when I ran npm run lint

src/combobox/combobox.component.spec.ts:36:9
ERROR: 36:9    quotemark       ' should be "
ERROR: 210:34  quotemark       ' should be "

src/combobox/combobox.component.ts:699:1
ERROR: 699:1   indent          tab indentation expected
ERROR: 700:1   indent          tab indentation expected
ERROR: 701:1   indent          tab indentation expected
ERROR: 702:1   indent          tab indentation expected
ERROR: 703:1   indent          tab indentation expected
ERROR: 704:1   indent          tab indentation expected

src/datepicker/datepicker.stories.ts:171:32
ERROR: 171:32  trailing-comma  Unnecessary trailing comma

Unrelated to my PR though

I'll have that resolved in a chore PR!

@nizamial09
Copy link
Contributor Author

I'll have that resolved in a chore PR!

cool, thanks

@Akshat55 Akshat55 changed the title fix 3078: ensure proper namespace for title attr fix: ensure proper namespace for title attr Nov 29, 2024
@Akshat55 Akshat55 merged commit 24ffbfe into carbon-design-system:master Nov 29, 2024
14 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.56.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.0.0-rc.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akshat55 Akshat55 Akshat55 approved these changes

Assignees
No one assigned
Labels
released on @latest released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon directive is not properly setting the title inside SVG as tooltip
2 participants
@nizamial09 @Akshat55