-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(StaticNotification): add actionButton props #15804
feat(StaticNotification): add actionButton props #15804
Conversation
Signed-off-by: Edward Fink <[email protected]>
DCO Assistant Lite bot All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
345732e
…m#15804) Signed-off-by: Edward Fink <[email protected]>
Following onto #15532 , this makes the new StaticNotification more visibly like the ActionableNotifcation.
Changelog
New
actionButtonLabel
on andonActionButtonClicked
props that ActionableNotification has.Changed
Testing / Reviewing
Let me know if any changes are needed. I'm happy to iterate on it. We're currently blocked from picking up any carbon builds until we can get this whole flow of focus grabbing on Actionable resolved.