feat(StaticNotification): add actionButton props #15804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Fink <[email protected]>
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Feb 26, 2024
Merged
via the queue into
carbon-design-system:main
with commit Feb 26, 2024
345732e
22 checks passed
mHuzefa
pushed a commit
to mHuzefa/carbon
that referenced
this pull request
Feb 27, 2024
…m#15804) Signed-off-by: Edward Fink <[email protected]>
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following onto #15532 , this makes the new StaticNotification more visibly like the ActionableNotifcation.
Changelog
New
actionButtonLabelon andonActionButtonClickedprops that ActionableNotification has.Changed
Testing / Reviewing
Let me know if any changes are needed. I'm happy to iterate on it. We're currently blocked from picking up any carbon builds until we can get this whole flow of focus grabbing on Actionable resolved.