-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update column names for gnomad v4 update #63
base: hg38
Are you sure you want to change the base?
Conversation
anjalijain22
commented
Aug 13, 2024
•
edited
Loading
edited
- Updated column names to reflect new columns in gnomad v4 update such as Gnomad_fafmax_faf95_max and Gnomad_af_grpmax
- Use this cre branch in conjunction with this crg2 branch gnomad V4 update crg2#231
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Do you mind moving the Gnomad_male_ac
column next to Gnomad_hom
? I know this is just inherited from the hg19 pipeline but we might as well move it (e.g. I changed it for crg2-pacbio).
I'm wondering if we should now be filtering on Gnomad_fafmax_faf95_max
instead of Gnomad_af_grpmax
. My understanding is that Gnomad_fafmax_faf95_max
corresponds to the GroupMax filtering allele frequency (FAF), which excludes bottlenecked genetic ancestry groups. The FAF is described here.
… closer in report; updated scripts to slurm
Changes:
Issues to be addressed before merging: |