Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the red flag colour to be fip red #324

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

ethanWallace
Copy link
Collaborator

Summary | Résumé

Update the --gcds-color-red-flag token to use FIP red to be compliant with FIP policy.

Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just one tiny thing - could we change the comment to say FIP red instead for consistency since that's how they have it written on the Federal Identity Program page for colours? TIA!

"type": "color",
"comment": "Signature flag colour"
"comment": "Signature flag colour - Fip red"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"comment": "Signature flag colour - Fip red"
"comment": "Signature flag colour - FIP red"

@ethanWallace ethanWallace merged commit 017f15b into main Sep 24, 2024
1 check passed
@ethanWallace ethanWallace deleted the fix/update-red-flag-colour branch September 24, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants