Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update the red flag colour to be fip red #324

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: Update the red flag colour to be fip red #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aeaf81
fix: Update the red flag colour to be fip red
ethanWallace Sep 18, 2024
0e62870
Update comment
ethanWallace Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/figma/figma.tokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"type": "color"
},
"flag": {
"value": "#FF0000",
"value": "#eb2d37",
"type": "color"
}
},
Expand Down Expand Up @@ -3978,7 +3978,7 @@
"signature": {
"color": {
"flag": {
"value": "#FF0000",
"value": "#eb2d37",
"type": "color"
},
"text": {
Expand Down
4 changes: 2 additions & 2 deletions build/web/css/.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
--gcds-color-red-500: #d3080c; /* Must contrast 3:1 with white */
--gcds-color-red-700: #a62a1e; /* Must contrast 7:1 with white */
--gcds-color-red-900: #822117;
--gcds-color-red-flag: #ff0000; /* Signature flag colour */
--gcds-color-red-flag: #eb2d37; /* Signature flag colour - FIP red */
--gcds-color-yellow-100: #faedd1;
--gcds-color-yellow-500: #b3800f; /* Must contrast 3:1 with white */
--gcds-border-radius-sm: 0.1875rem; /* Global border: radius sm */
Expand Down Expand Up @@ -724,7 +724,7 @@
--gcds-side-nav-heading-margin: 0.5625rem;
--gcds-side-nav-heading-padding: 0.9375rem;
--gcds-side-nav-max-width: 20rem;
--gcds-signature-color-flag: #ff0000;
--gcds-signature-color-flag: #eb2d37;
--gcds-signature-color-text: #000000;
--gcds-signature-signature-height: 1.6875rem;
--gcds-signature-white-default: #ffffff;
Expand Down
2 changes: 1 addition & 1 deletion build/web/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
--gcds-color-red-500: #d3080c; /* Must contrast 3:1 with white */
--gcds-color-red-700: #a62a1e; /* Must contrast 7:1 with white */
--gcds-color-red-900: #822117;
--gcds-color-red-flag: #ff0000; /* Signature flag colour */
--gcds-color-red-flag: #eb2d37; /* Signature flag colour - FIP red */
--gcds-color-yellow-100: #faedd1;
--gcds-color-yellow-500: #b3800f; /* Must contrast 3:1 with white */
}
2 changes: 1 addition & 1 deletion build/web/css/base/color.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
--gcds-color-red-500: #d3080c; /* Must contrast 3:1 with white */
--gcds-color-red-700: #a62a1e; /* Must contrast 7:1 with white */
--gcds-color-red-900: #822117;
--gcds-color-red-flag: #ff0000; /* Signature flag colour */
--gcds-color-red-flag: #eb2d37; /* Signature flag colour - FIP red */
--gcds-color-yellow-100: #faedd1;
--gcds-color-yellow-500: #b3800f; /* Must contrast 3:1 with white */
}
2 changes: 1 addition & 1 deletion build/web/css/components.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@
--gcds-side-nav-heading-margin: 0.5625rem;
--gcds-side-nav-heading-padding: 0.9375rem;
--gcds-side-nav-max-width: 20rem;
--gcds-signature-color-flag: #ff0000;
--gcds-signature-color-flag: #eb2d37;
--gcds-signature-color-text: #000000;
--gcds-signature-signature-height: 1.6875rem;
--gcds-signature-white-default: #ffffff;
Expand Down
2 changes: 1 addition & 1 deletion build/web/css/components/signature.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/

:root {
--gcds-signature-color-flag: #ff0000;
--gcds-signature-color-flag: #eb2d37;
--gcds-signature-color-text: #000000;
--gcds-signature-signature-height: 1.6875rem;
--gcds-signature-white-default: #ffffff;
Expand Down
4 changes: 2 additions & 2 deletions build/web/css/tokens.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
--gcds-color-red-500: #d3080c; /* Must contrast 3:1 with white */
--gcds-color-red-700: #a62a1e; /* Must contrast 7:1 with white */
--gcds-color-red-900: #822117;
--gcds-color-red-flag: #ff0000; /* Signature flag colour */
--gcds-color-red-flag: #eb2d37; /* Signature flag colour - FIP red */
--gcds-color-yellow-100: #faedd1;
--gcds-color-yellow-500: #b3800f; /* Must contrast 3:1 with white */
--gcds-border-radius-sm: 0.1875rem; /* Global border: radius sm */
Expand Down Expand Up @@ -724,7 +724,7 @@
--gcds-side-nav-heading-margin: 0.5625rem;
--gcds-side-nav-heading-padding: 0.9375rem;
--gcds-side-nav-max-width: 20rem;
--gcds-signature-color-flag: #ff0000;
--gcds-signature-color-flag: #eb2d37;
--gcds-signature-color-text: #000000;
--gcds-signature-signature-height: 1.6875rem;
--gcds-signature-white-default: #ffffff;
Expand Down
4 changes: 2 additions & 2 deletions build/web/scss/.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ $gcds-color-red-100: #fbddda;
$gcds-color-red-500: #d3080c; // Must contrast 3:1 with white
$gcds-color-red-700: #a62a1e; // Must contrast 7:1 with white
$gcds-color-red-900: #822117;
$gcds-color-red-flag: #ff0000; // Signature flag colour
$gcds-color-red-flag: #eb2d37; // Signature flag colour - FIP red
$gcds-color-yellow-100: #faedd1;
$gcds-color-yellow-500: #b3800f; // Must contrast 3:1 with white
$gcds-border-radius-sm: 0.1875rem; // Global border: radius sm
Expand Down Expand Up @@ -722,7 +722,7 @@ $gcds-side-nav-heading-font: 700 1.58203125rem/126.41975308641975% "Lato", sans-
$gcds-side-nav-heading-margin: 0.5625rem;
$gcds-side-nav-heading-padding: 0.9375rem;
$gcds-side-nav-max-width: 20rem;
$gcds-signature-color-flag: #ff0000;
$gcds-signature-color-flag: #eb2d37;
$gcds-signature-color-text: #000000;
$gcds-signature-signature-height: 1.6875rem;
$gcds-signature-white-default: #ffffff;
Expand Down
2 changes: 1 addition & 1 deletion build/web/scss/base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ $gcds-color-red-100: #fbddda;
$gcds-color-red-500: #d3080c; // Must contrast 3:1 with white
$gcds-color-red-700: #a62a1e; // Must contrast 7:1 with white
$gcds-color-red-900: #822117;
$gcds-color-red-flag: #ff0000; // Signature flag colour
$gcds-color-red-flag: #eb2d37; // Signature flag colour - FIP red
$gcds-color-yellow-100: #faedd1;
$gcds-color-yellow-500: #b3800f; // Must contrast 3:1 with white
2 changes: 1 addition & 1 deletion build/web/scss/base/color.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ $gcds-color-red-100: #fbddda;
$gcds-color-red-500: #d3080c; // Must contrast 3:1 with white
$gcds-color-red-700: #a62a1e; // Must contrast 7:1 with white
$gcds-color-red-900: #822117;
$gcds-color-red-flag: #ff0000; // Signature flag colour
$gcds-color-red-flag: #eb2d37; // Signature flag colour - FIP red
$gcds-color-yellow-100: #faedd1;
$gcds-color-yellow-500: #b3800f; // Must contrast 3:1 with white
2 changes: 1 addition & 1 deletion build/web/scss/components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ $gcds-side-nav-heading-font: 700 1.58203125rem/126.41975308641975% "Lato", sans-
$gcds-side-nav-heading-margin: 0.5625rem;
$gcds-side-nav-heading-padding: 0.9375rem;
$gcds-side-nav-max-width: 20rem;
$gcds-signature-color-flag: #ff0000;
$gcds-signature-color-flag: #eb2d37;
$gcds-signature-color-text: #000000;
$gcds-signature-signature-height: 1.6875rem;
$gcds-signature-white-default: #ffffff;
Expand Down
2 changes: 1 addition & 1 deletion build/web/scss/components/signature.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

// Do not edit directly.

$gcds-signature-color-flag: #ff0000;
$gcds-signature-color-flag: #eb2d37;
$gcds-signature-color-text: #000000;
$gcds-signature-signature-height: 1.6875rem;
$gcds-signature-white-default: #ffffff;
Expand Down
4 changes: 2 additions & 2 deletions build/web/scss/tokens.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ $gcds-color-red-100: #fbddda;
$gcds-color-red-500: #d3080c; // Must contrast 3:1 with white
$gcds-color-red-700: #a62a1e; // Must contrast 7:1 with white
$gcds-color-red-900: #822117;
$gcds-color-red-flag: #ff0000; // Signature flag colour
$gcds-color-red-flag: #eb2d37; // Signature flag colour - FIP red
$gcds-color-yellow-100: #faedd1;
$gcds-color-yellow-500: #b3800f; // Must contrast 3:1 with white
$gcds-border-radius-sm: 0.1875rem; // Global border: radius sm
Expand Down Expand Up @@ -722,7 +722,7 @@ $gcds-side-nav-heading-font: 700 1.58203125rem/126.41975308641975% "Lato", sans-
$gcds-side-nav-heading-margin: 0.5625rem;
$gcds-side-nav-heading-padding: 0.9375rem;
$gcds-side-nav-max-width: 20rem;
$gcds-signature-color-flag: #ff0000;
$gcds-signature-color-flag: #eb2d37;
$gcds-signature-color-text: #000000;
$gcds-signature-signature-height: 1.6875rem;
$gcds-signature-white-default: #ffffff;
Expand Down
4 changes: 2 additions & 2 deletions tokens/base/color/tokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@
},
"red": {
"flag": {
"value": "#FF0000",
"value": "#eb2d37",
"type": "color",
"comment": "Signature flag colour"
"comment": "Signature flag colour - FIP red"
},
"100": {
"value": "#FBDDDA",
Expand Down