Fix for Issue 4 (DoUnlock NPEs on concurrent Mac/non-Mac client access) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoLock#_macLockRequest flag, causing all future UNLOCK requests from non-Mac clients to fail.
package private so that compiler will help limit state access/mutation.
isn't used from elsewhere.
outside of ResourceLocks.
execute method does not need to be synchronized.
methods need to be synchronized.
to remain synchronized as there are *lots* of shared mutable state.
DoUnlock#execute().
|
seems legit for me. |
braully
pushed a commit
to braully/webdav-servlet
that referenced
this pull request
Dec 22, 2021
FUN-15544 fix webdav locking issues in macos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issue where one Mac client access permanently sets the DoLock#_macLockRequest flag, causing all future UNLOCK requests from non-Mac clients to fail.