Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue 4 (DoUnlock NPEs on concurrent Mac/non-Mac client access) #5

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Fix for Issue 4 (DoUnlock NPEs on concurrent Mac/non-Mac client access) #5

wants to merge 27 commits into from

Commits on Jan 5, 2014

  1. Resolved issue where one Mac client access permanently sets the 

    DoLock#_macLockRequest flag, causing all future UNLOCK requests from
non-Mac clients to fail.
    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    fb41c6f View commit details
    Browse the repository at this point in the history

  2. Made instance variables final where possible, mode protected variables 

    package private so that compiler will help limit state access/mutation.
    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    697a4f9 View commit details
    Browse the repository at this point in the history

  3. Made methods only used by ResourceLocks package private to guarantee it 

    isn't used from elsewhere.
    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    4e556f3 View commit details
    Browse the repository at this point in the history

  4. Made add/remove lockedObjectOwner synchronized, since it's invoke 

    outside of ResourceLocks.
    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    3007f98 View commit details
    Browse the repository at this point in the history

  5. Made LockedObject shared variables volatile.

    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    0a4bf68 View commit details
    Browse the repository at this point in the history

  6. Removed TODO comments.

    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    60f001c View commit details
    Browse the repository at this point in the history

  7. Made DoUnlock state variables final so that we can be more certain the 

    execute method does not need to be synchronized.
    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    36f309d View commit details
    Browse the repository at this point in the history

  8. Reduced mutability and visibility of shared state to help determine what 

    methods need to be synchronized.
    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    7c568e1 View commit details
    Browse the repository at this point in the history

  9. Made shared mutable state volatile.

    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    e93d86f View commit details
    Browse the repository at this point in the history

  10. Made ResourceLocks#checkTimeouts synchronized.

    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    40beb2a View commit details
    Browse the repository at this point in the history

  11. Removed unused variable from DoLock.

    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    92c31b3 View commit details
    Browse the repository at this point in the history

  12. Made immutable state variables final in DoLock. DoLock#execute will need 

    to remain synchronized as there are *lots* of shared mutable state.
    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    daab9b1 View commit details
    Browse the repository at this point in the history

  13. Log instead of printStackTrace() on LockFailedException in 

    DoUnlock#execute().
    @jackgene
    jackgene committed Jan 5, 2014
    Configuration menu
    Copy the full SHA
    56a5701 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2014

  1. Allow getlastmodified on collections.

    @jackgene
    jackgene committed Jan 30, 2014
    Configuration menu
    Copy the full SHA
    68e97ff View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2014

  1. Fixed unit tests.

    Jack Leow committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    5c12f6a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/jackgene/webdav-servlet

    Jack Leow committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    34eed54 View commit details
    Browse the repository at this point in the history

  3. Implemented workaround for shared variable mutation issue.

    @jackgene
    jackgene committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    9082961 View commit details
    Browse the repository at this point in the history

  4. Removed unused variable.

    @jackgene
    jackgene committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    32c6355 View commit details
    Browse the repository at this point in the history

  5. Upgraded Gradle, and simplified build to the bare minimum required to 

    build.
    @jackgene
    jackgene committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    c6c4fa3 View commit details
    Browse the repository at this point in the history

  6. Re-introduced and upgraded gradle wrapper.

    @jackgene
    jackgene committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    272ce8a View commit details
    Browse the repository at this point in the history

  7. Removed unused file, and updated .gitignore.

    @jackgene
    jackgene committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    d92b32b View commit details
    Browse the repository at this point in the history

  8. Added gradle wrapper jar.

    @jackgene
    jackgene committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    e58ccc3 View commit details
    Browse the repository at this point in the history

  9. Added .gitignore.

    @jackgene
    jackgene committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    905ec78 View commit details
    Browse the repository at this point in the history

  10. Flushed output more aggressively.

    @jackgene
    jackgene committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    675eb53 View commit details
    Browse the repository at this point in the history

  11. Added serialVersionUID, removed unused imports.

    @jackgene
    jackgene committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    a61d639 View commit details
    Browse the repository at this point in the history

  12. Removed/ignored more unused stuff.

    @jackgene
    jackgene committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    f0c9f84 View commit details
    Browse the repository at this point in the history

  13. Ignored bin.

    @jackgene
    jackgene committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    ef09d06 View commit details
    Browse the repository at this point in the history