h264: Use asynchronous decoding when possible #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to hide the latency of the software decoder when operating in buffered mode which should help games that are picky about slow decoding times
|
Super Smash Bros For Wii U intro cutscene still gets easily stuck even with this PR |
|
Thanks for testing this. Can you enable |
|
The good news is that from the log it looks like the PR is working and decoding times are very low. Bad news is that this means there are other factors outside the decoder itself that can trigger the freezes. Maybe slow file reading speed? I will do some digging when I get a chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By design
h264.rplexposes only a synchronous API where decoding only happens duringH264DECExecutecalls. However, if H264DEC runs in buffered mode we can use asynchronous decoding under the hood while still simulating a synchronous API on top of it. In most cases this lets us hide the latency of our software decoder which helps with games that are picky about decoding times.Should help with #217
Marking this as draft for now since I still have to go through all the games with videos to make sure there are no regressions.