Build and release x86+arm manifests #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use docker buildx GH action to build x86_64/amd64 as well as arm64 container images in build and release action. Signed-off-by: Blaine Gardner <[email protected]>
|
This is one of the things currently blocking me from running COSI in my own minikube env. Once this is in, a new release would be nice in order to have the arm build, or to somehow manually force it to run. |
thotz
reviewed
Jul 19, 2023
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
My editor ensures there is a newline at the end of files, which is standard.
thotz
reviewed
Jul 19, 2023
| - name: Set up QEMU for multi-arch builds | ||
| uses: docker/setup-qemu-action@v2 | ||
| with: | ||
| platforms: 'arm64' |
There was a problem hiding this comment.
amd64 will be built by default??
There was a problem hiding this comment.
The host arch is amd64 so QEMU is not needed for that.
thotz
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use docker buildx GH action to build x86_64/amd64 as well as arm64
container images in build and release action.
Signed-off-by: Blaine Gardner [email protected]