Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and release x86+arm manifests #23

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Build and release x86+arm manifests #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/tag-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,22 @@ jobs:
username: ${{ secrets.QUAY_USERNAME }}
password: ${{ secrets.QUAY_PASSWORD }}

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Set up QEMU for multi-arch builds
uses: docker/setup-qemu-action@v2
with:
platforms: 'arm64'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amd64 will be built by default??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The host arch is amd64 so QEMU is not needed for that.


- name: Build bundle container image
uses: docker/build-push-action@v4
with:
context: .
file: Dockerfile
push: true
tags: quay.io/ceph/cosi:${{ github.ref_name }}
platforms: linux/amd64,linux/arm64

publish_release:
name: Publish a release based on the tag
Expand All @@ -64,4 +73,4 @@ jobs:
tag: ${{ github.ref_name }}
artifacts: "examples/*/*.yaml"
generateReleaseNotes: true
token: ${{ secrets.GITHUB_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintentional ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor ensures there is a newline at the end of files, which is standard.