-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tfi, poc): Provide Your Types of Financial Institutions - Skeleton; Point of Contact - Skeleton, Input Validation, Error Handling, Submission #300
Conversation
- [Add] Fetch Institution data - [Add] Breadcrumb to return to View page
- [Add] Review FI details
…d include in submitted DTO
…nd include in submitted DTO
…de in submitted DTO
…de in submitted DTO
…"Other" details text
…ion of defaultValues
Co-authored-by: S T <[email protected]>
- Improved population of existing form data - Temp fix for TextArea resizing issue - Implements `Clear form` functionality
Currently, in condition for review. |
src/pages/Filing/UpdateFinancialProfile/TypesFinancialInstitutionSection.tsx
Show resolved
Hide resolved
changeOrigin: true, | ||
secure: false, | ||
}, | ||
"/v1/filing": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes will prevent CORS errors. Be sure to set SBL_FILING_BASE_URL
in your .env
If you want to test the 1.) Run the below script for the
2.) Then attempt the
will still function properly to verify that the request worked properly as the contact information will be returned. {
"id": 2,
"first_name": "asdf",
"last_name": "asdf",
"hq_address_street_1": "23423",
"hq_address_street_2": "",
"hq_address_city": "234",
"hq_address_state": "arizona",
"hq_address_zip": "23451",
"email": "[email protected]",
"phone": "234-234-2344"
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍🏾
closes #284
closes #287
closes #297
closes #288
Changes
v1/filing
as a vite proxy point.submitPointOfContact
request for use on the Point of Contact form.FormMain
component which is a wrapper component for<form />
.Screenshots
How to Test
Pre-requisites
yarn update
, wipe all Docker containers and Docker volumes, runyarn seed
.SBL_FILING_BASE_URL="http://localhost:8882"
to your.env
.Test Set 0
Fieldgroup
and ensure the 770px (48.125rem) limit is met (including borders, margins, etc).Test Set 1
toggleRouting()
to disable enforced routinghttp://localhost:8899/point-of-contact
to verify Point of ContactTest Set 2
toggleRouting()
to disable enforced routinghttp://localhost:8899/types-financial-institutions
to verify Types of Financial Institutions. No functionality at this moment.TODO
submitPointOfContact
requires a correspondinglei
andfiling_period
, so temporarily using HARDCODED values.Update Your Financial Institution
to be completed before further updates to the zod schema, input validation and error handling.Notes
submitPointOfContact
request will return an500 Internal Server Error
. This can be ignored, see here.