Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tfi, poc): Provide Your Types of Financial Institutions - Skeleton; Point of Contact - Skeleton, Input Validation, Error Handling, Submission #300

Merged
merged 67 commits into from
Mar 19, 2024
Merged

feat(tfi, poc): Provide Your Types of Financial Institutions - Skeleton; Point of Contact - Skeleton, Input Validation, Error Handling, Submission #300

merged 67 commits into from
Mar 19, 2024

Commits on Feb 22, 2024

  1. fix: [CrumbTrail] Allow conditional entries

    @meissadia
    meissadia committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    48949ca View commit details
    Browse the repository at this point in the history

  2. fix: [UpdateInstitutionProfile] 

    - [Add] Fetch Institution data
- [Add] Breadcrumb to return to View page
    @meissadia
    meissadia committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    240aff4 View commit details
    Browse the repository at this point in the history

  3. fix: [UpdateInstitutionProfile] 

    - [Add] Review FI details
    @meissadia
    meissadia committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    adf4a18 View commit details
    Browse the repository at this point in the history

  4. feat: [UpdateFinancialProfile] Display FinancialInstitutionDetails

    @meissadia
    meissadia committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d0a4a62 View commit details
    Browse the repository at this point in the history

  5. feat: [UpdateFinancialProfile] Display FinancialInstitutionDetails an… 

    …d include in submitted DTO
    @meissadia
    meissadia committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    661ae59 View commit details
    Browse the repository at this point in the history

  6. feat: [UpdateFinancialProfile] Display UpdateIdentifyingInformation a… 

    …nd include in submitted DTO
    @meissadia
    meissadia committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    3b3233b View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. feat: [InputEntry] Support display of (optional) label

    @meissadia
    meissadia committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1d4415f View commit details
    Browse the repository at this point in the history

  2. fix: Lint error

    @meissadia
    meissadia committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c527d56 View commit details
    Browse the repository at this point in the history

  3. feat: [UpdateFinancialProfile] Display AffiliateInformation and inclu… 

    …de in submitted DTO
    @meissadia
    meissadia committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    de66307 View commit details
    Browse the repository at this point in the history

  4. feat: [LabelOptional] Extract to a reusable component

    @meissadia
    meissadia committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b926c51 View commit details
    Browse the repository at this point in the history

  5. feat: [UpdateFinancialProfile] Display AffiliateInformation and inclu… 

    …de in submitted DTO
    @meissadia
    meissadia committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    190eb16 View commit details
    Browse the repository at this point in the history

  6. fix: [UpdateAffiliateInformation] Display initial checkbox state and … 

    …"Other" details text
    @meissadia
    meissadia committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    3373a31 View commit details
    Browse the repository at this point in the history

  7. feat: [UpdateFinancialProfile] Simulated success upon form submission

    @meissadia
    meissadia committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    6b5187e View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Merge branch 'main' into 222-update-fi-profile-phase1

    @meissadia
    meissadia committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    7544f44 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Merge branch 'main' into 222-update-fi-profile-phase1

    @meissadia
    meissadia committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    33c0a9b View commit details
    Browse the repository at this point in the history

  2. fix: [UpdateAffiliateInformation] Extract UFPForm in prep for generat… 

    …ion of defaultValues
    @meissadia
    meissadia committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c20b8c6 View commit details
    Browse the repository at this point in the history

  3. fix: [UpdateAffiliateInformation] Change filename case

    @meissadia
    meissadia committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    eb770a8 View commit details
    Browse the repository at this point in the history

  4. fix: removed double reference

    @shindigira
    shindigira committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    3236824 View commit details
    Browse the repository at this point in the history

  5. Update src/components/LabelOptional.tsx 

    Co-authored-by: S T <[email protected]>
    @meissadia @shindigira
    meissadia and shindigira authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4753436 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. [UpdateInstitutionProfile] 

    -  Improved population of existing form data
- Temp fix for TextArea resizing issue
- Implements `Clear form` functionality
    @meissadia
    meissadia committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6508285 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Merge branch 'main' into 222-update-fi-profile-phase1

    @meissadia
    meissadia authored Feb 29, 2024
    Configuration menu
    Copy the full SHA
    98f3ea0 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. refactor(InputEntry): InputEntry's label prop only expects string

    @shindigira
    shindigira committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    8cb40cf View commit details
    Browse the repository at this point in the history

  2. feat(poc): Point of Contact - start

    @shindigira
    shindigira committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    f212854 View commit details
    Browse the repository at this point in the history

  3. feat(poc): point of contact wip2

    @shindigira
    shindigira committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    9b69367 View commit details
    Browse the repository at this point in the history

  4. style: InputEntry accepts a className prop

    @shindigira
    shindigira committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    0dc2371 View commit details
    Browse the repository at this point in the history

  5. feat(poc): added button group

    @shindigira
    shindigira committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    240fbb2 View commit details
    Browse the repository at this point in the history

  6. feat(poc): use of Select for states

    @shindigira
    shindigira committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    05c7b70 View commit details
    Browse the repository at this point in the history

  7. style: FieldGroup box-border at 770px

    @shindigira
    shindigira committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    431bb87 View commit details
    Browse the repository at this point in the history

  8. feat: LabelOptional - Street Address line 2

    @shindigira
    shindigira committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    0060dd5 View commit details
    Browse the repository at this point in the history

  9. style: fixed InputEntry's custom className

    @shindigira
    shindigira committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    fbab612 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. [Update FI] New TODO - Navigate based on validation success

    @meissadia
    meissadia committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    64b66c4 View commit details
    Browse the repository at this point in the history

  2. [Update FI] Add placeholder for InputEntry prop errorMessage

    @meissadia
    meissadia committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6b802db View commit details
    Browse the repository at this point in the history

  3. Merge branch '222-update-fi-profile-phase1' of https://github.com/cfp… 

    …b/sbl-frontend into 222-update-fi-profile-phase1
    @meissadia
    meissadia committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    e1975b3 View commit details
    Browse the repository at this point in the history

  4. [FormSectionWrapper] Extract to shared, reusable component

    @meissadia
    meissadia committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    926e154 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into 222-update-fi-profile-phase3-beta

    @meissadia
    meissadia committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8b948fd View commit details
    Browse the repository at this point in the history

  6. Merge branch '222-update-fi-profile-phase1' into 222-update-fi-profil… 

    …e-phase3-beta
    @meissadia
    meissadia committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    47e3df6 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge branch 'main' into 222-update-fi-profile-phase3-beta

    @meissadia
    meissadia committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    76c074f View commit details
    Browse the repository at this point in the history

  2. [LabelOptional] Remove dead code

    @meissadia
    meissadia committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    86ed9d4 View commit details
    Browse the repository at this point in the history

  3. feat: Zod Schema Update - Centralize form types, Regex checks to TIN,… 

    … LEI (#290)

closes #273 

### Changes
- feat: Moved `ProfileForm` types to `types/formTypes`.
- feat: Addressed the extra _approval_ field on `Get Associated
Institution` request.
- feat: Adds the `getZodKeys` function to extract flattened fields from
Zod Schemas
- todo: Added TODO for handling the edge case of where fetched financial
institutions fail input validation -
#292

### Notes
@meissadia This should be used in Phase 4 of Update your Financial
Institution - Zod and TypeScript handling


### Reference
- getZodKeys: colinhacks/zod#2134
    @shindigira
    shindigira authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    f5fb4d6 View commit details
    Browse the repository at this point in the history

  4. fix: cpf button type fix

    @shindigira
    shindigira committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    c3d809c View commit details
    Browse the repository at this point in the history

  5. style: Remove financial institution button - bottom 15px padding

    @shindigira
    shindigira committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9ae4515 View commit details
    Browse the repository at this point in the history

  6. fix: resolved merge conflict

    @shindigira
    shindigira committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9907e35 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Update src/pages/ProfileForm/Step1Form/Step1Form.tsx 

    Co-authored-by: S T <[email protected]>
    @meissadia @shindigira
    meissadia and shindigira authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    f609163 View commit details
    Browse the repository at this point in the history

  2. feat(poc): added states.json

    @shindigira
    shindigira committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d7bd402 View commit details
    Browse the repository at this point in the history

  3. chore: updated label items on PoC

    @shindigira
    shindigira committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9592dc8 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. resolved merge conflicts

    @shindigira
    shindigira committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ba79747 View commit details
    Browse the repository at this point in the history

  2. feat(tfi): Provide Types of Financial Institutions -- start

    @shindigira
    shindigira committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6c4b927 View commit details
    Browse the repository at this point in the history

  3. feat: created a Form component

    @shindigira
    shindigira committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    dc1d04c View commit details
    Browse the repository at this point in the history

  4. feat: started TypesFinancialInstitutionSection

    @shindigira
    shindigira committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    bd301be View commit details
    Browse the repository at this point in the history

  5. feat: functional skeleton

    @shindigira
    shindigira committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2096aac View commit details
    Browse the repository at this point in the history

  6. chore: renamed Form to FormMain, typescript in TypesFinancialInstitut… 

    …ionSection
    @shindigira
    shindigira committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    102770e View commit details
    Browse the repository at this point in the history

  7. feat: Point of Contact - Zod Schema & TypeScript

    @shindigira
    shindigira committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8984026 View commit details
    Browse the repository at this point in the history

  8. feat: poc API request WIP

    @shindigira
    shindigira committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6cd3332 View commit details
    Browse the repository at this point in the history

  9. feat: modified proxy to handle the sbl filing app

    @shindigira
    shindigira committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    18daed9 View commit details
    Browse the repository at this point in the history

  10. fix: resolved merge conflict

    @shindigira
    shindigira committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    803cc97 View commit details
    Browse the repository at this point in the history

  11. chore: added comment related to the international phone number regex

    @shindigira
    shindigira committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ac42b44 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. chore: added Washington DC as a 'state'

    @shindigira
    shindigira committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    9c91bb5 View commit details
    Browse the repository at this point in the history

  2. fix: resolved merge conflicts from 'main'

    @shindigira
    shindigira committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8953805 View commit details
    Browse the repository at this point in the history

  3. comment: added phone number regex comment

    @shindigira
    shindigira committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a323131 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge branch 'main' of github.com:cfpb/sbl-frontend into 222-284-287-… 

    …types-of-financial-institutions
    @shindigira
    shindigira committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    234402f View commit details
    Browse the repository at this point in the history

  2. chore: renamed variable

    @shindigira
    shindigira committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9dadc05 View commit details
    Browse the repository at this point in the history

  3. feat(poc api): hardcoded api request

    @shindigira
    shindigira committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    86360b4 View commit details
    Browse the repository at this point in the history

  4. updated point of contact regex in zod schema

    @shindigira
    shindigira committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    da170ee View commit details
    Browse the repository at this point in the history

  5. feat(submitPointOfContact): API Request using hardcoded values, wip

    @shindigira
    shindigira committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    67bdd6f View commit details
    Browse the repository at this point in the history

  6. chore: removed 'id' as it is not needed in the request

    @shindigira
    shindigira committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    5b762a8 View commit details
    Browse the repository at this point in the history

  7. style(SectionIntro): 670px max-width and box-border (includes padding… 

    …/margins/etc)
    @shindigira
    shindigira committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a545bd3 View commit details
    Browse the repository at this point in the history

  8. style: SectionIntro 30px margin-bottom

    @shindigira
    shindigira committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    06ecfb4 View commit details
    Browse the repository at this point in the history