user/darkhttpd: new package #1460
Open
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttyyls
changed the title
ttyyls
force-pushed
the
darkhttpd
branch
3 times, most recently
from
b028700
to
e1c9ac6
Compare
ttyyls
changed the title
triallax
reviewed
Oct 4, 2024
Comment on lines
+13
to
+18
| # no tests defined | ||
| options = ["!check"] | ||
|
|
||
|
|
||
| def install(self): | ||
| self.install_license("COPYING") |
There was a problem hiding this comment.
COPYING doesn't contain a copyright notice, so you can either e.g. import my patch from emikulic/darkhttpd#70 or probably do this instead:
Suggested change
| # no tests defined | |
| options = ["!check"] | |
| def install(self): | |
| self.install_license("COPYING") | |
| # check: no tests defined | |
| # distlicense: license file doesn't include copyright notice, see | |
| # https://github.com/emikulic/darkhttpd/pull/70 | |
| options = ["!check", "!distlicense"] | |
| def install(self): |
There was a problem hiding this comment.
the patch itself looks good and I suppose necessary for the license to be coherent. But a copyight notice is included in the executable itself and gets displayed first when run, as such Im not sure if it's necessary to block on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.