Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user/darkhttpd: new package #1460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −0
Open

user/darkhttpd: new package #1460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions user/darkhttpd/template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
pkgname = "darkhttpd"
pkgver = "1.16"
pkgrel = 0
build_style = "makefile"
make_use_env = True
pkgdesc = "Single-threaded static content webserver"
maintainer = "ttyyls <[email protected]>"
license = "ISC"
url = "https://unix4lyfe.org/darkhttpd"
source = f"https://github.com/emikulic/darkhttpd/archive/v{pkgver}.tar.gz"
sha256 = "ab97ea3404654af765f78282aa09cfe4226cb007d2fcc59fe1a475ba0fef1981"
hardening = ["vis", "cfi"]
# no tests defined
options = ["!check"]


def install(self):
self.install_license("COPYING")
Comment on lines +13 to +18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COPYING doesn't contain a copyright notice, so you can either e.g. import my patch from emikulic/darkhttpd#70 or probably do this instead:

Suggested change
# no tests defined
options = ["!check"]
def install(self):
self.install_license("COPYING")
# check: no tests defined
# distlicense: license file doesn't include copyright notice, see
# https://github.com/emikulic/darkhttpd/pull/70
options = ["!check", "!distlicense"]
def install(self):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the patch itself looks good and I suppose necessary for the license to be coherent. But a copyight notice is included in the executable itself and gets displayed first when run, as such Im not sure if it's necessary to block on it

self.install_bin("darkhttpd")