-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow injecting user synchronization modules #56
Conversation
9b964f0
to
ad135e3
Compare
Hi @mkurc-ant , what is the status of this issue? |
Hi @varuns-nvidia. This PR is ready but marked as draft as it is based on #54 (shared codebase) which has not yet been reviewed. |
Signed-off-by: Maciej Kurc <[email protected]>
ad135e3
to
ef894c7
Compare
@varuns-nvidia FYI this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user_rv_sync placeholder module should not contain an "initial" block.
The user_rv_sync module should not be multi-bit width, since it has no synchronization qualifiers for multi-bit signal synchronization.
Recommend user_rv_sync is single bit in/out.
Recommend user_rv_sync instantiates rvdff behavioural flop model from existing beh_lib.sv.
… initial state Signed-off-by: Maciej Kurc <[email protected]>
@nstewart-amd I changed the required user synchronizer cell model to be 1-bit and without any initial blocks. I left the behavioral code in |
This PR allows injection of modules containing synchronization flip-flops (answers #51).
The config script allows to set additional parameters which end up in code as capitalized defines:
tech_specific_rv_sync - enables usage of the user module
user_rv_sync - specifies the module name
The PR is based on #54 and should be reviewed and merged after it.