Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign support #251

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Sign support #251

merged 3 commits into from
Nov 21, 2023

Conversation

hpya93
Copy link
Contributor

@hpya93 hpya93 commented Nov 2, 2023 •
edited
Loading

Hi @jhand2
Test for Sign command is added separately.
The following are tested in this PR

  • Testcase for Sign command in Simulation context
  • Testcase for Symmetric Signing
  • Testcase for Asymmetric signing and verification

Update:

  • Bug in Rust side is fixed, Instead of setting Flag bit 30, flag bit 31 is set for symmetric signing. (merged in PR 255)
  • These items were covered in a common testcases (merged in PR 255)
    • Sign command in Default context
    • Wrong Locality
    • Context handle

jhand2
jhand2 reviewed Nov 9, 2023
View reviewed changes
verification/abi.go Outdated Show resolved Hide resolved
jhand2
jhand2 reviewed Nov 13, 2023
View reviewed changes
verification/certifyKey.go Outdated Show resolved Hide resolved
verification/sign.go Outdated Show resolved Hide resolved
verification/sign.go Show resolved Hide resolved
verification/sign.go Outdated Show resolved Hide resolved
verification/sign.go Outdated Show resolved Hide resolved
verification/sign.go Outdated Show resolved Hide resolved
verification/sign.go Outdated Show resolved Hide resolved
verification/tagTCI.go Outdated Show resolved Hide resolved
@hpya93 hpya93 closed this Nov 20, 2023
@hpya93
Copy link
Contributor Author

hpya93 commented Nov 20, 2023 •
edited
Loading

Synced branch with PR258, PR253 merge

@hpya93 hpya93 reopened this Nov 20, 2023
hpya93
hpya93 commented Nov 20, 2023
View reviewed changes
verification/simulator.go Outdated Show resolved Hide resolved
jhand2 added a commit to jhand2/caliptra-dpe that referenced this pull request Nov 21, 2023
@jhand2
Restore ExtendTCI Test
051473e 
Restore the ExtendTCI test removed in chipsalliance#251. Since TagTCI was removed,
this tests needed to be refactored a bit.
@jhand2 jhand2 mentioned this pull request Nov 21, 2023
Open
hpya93
hpya93 commented Nov 21, 2023
View reviewed changes
verification/extendTCI.go Outdated Show resolved Hide resolved
jhand2 added a commit to jhand2/caliptra-dpe that referenced this pull request Nov 21, 2023
@jhand2
Restore ExtendTCI Test
83fdd92 
Restore the ExtendTCI test removed in chipsalliance#251. Since TagTCI was removed,
this tests needed to be refactored a bit.
@jhand2 jhand2 mentioned this pull request Nov 21, 2023
Merged
@hpya93 hpya93 closed this Nov 21, 2023
@hpya93
Copy link
Contributor Author

hpya93 commented Nov 21, 2023

Synced code

@hpya93 hpya93 reopened this Nov 21, 2023
jhand2 added a commit that referenced this pull request Nov 21, 2023
@jhand2
Restore ExtendTCI Test
e364da7 
Restore the ExtendTCI test removed in #251. Since TagTCI was removed,
this tests needed to be refactored a bit.
jhand2
jhand2 previously approved these changes Nov 21, 2023
View reviewed changes
@jhand2 jhand2 merged commit d0c06e8 into chipsalliance:main Nov 21, 2023
1 check passed
@hpya93 hpya93 deleted the sign_support branch November 22, 2023 09:26
@sree-revoori1 sree-revoori1 mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhand2 jhand2 jhand2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hpya93 @jhand2