Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extendtci command as separate branch #253

Merged
merged 12 commits into from
Nov 20, 2023

Conversation

hpya93
Copy link
Contributor

@hpya93 hpya93 commented Nov 3, 2023

Hi @jhand2
Have added ExtendTCI command tests in separate branch

  • cross checking current and cumulative measurement - using GettaggedTci and CertifyKey returned DPE leaf cert's MultiTcbInfo extension
  • testing by deriving a child context and extending values to derived context - and cleanup derived context.

verification/abi.go Show resolved Hide resolved
verification/tagTCI.go Outdated Show resolved Hide resolved
verification/client.go Outdated Show resolved Hide resolved
@hpya93
Copy link
Contributor Author

hpya93 commented Nov 7, 2023

Hi @jhand2, Have rebased this branch with respect to main branch.

verification/verification.go Outdated Show resolved Hide resolved
verification/tagTCI.go Outdated Show resolved Hide resolved
verification/tagTCI.go Outdated Show resolved Hide resolved
verification/tagTCI.go Outdated Show resolved Hide resolved
verification/tagTCI.go Outdated Show resolved Hide resolved
verification/tagTCI.go Outdated Show resolved Hide resolved
verification/tagTCI.go Outdated Show resolved Hide resolved
verification/tagTCI.go Outdated Show resolved Hide resolved
@hpya93 hpya93 mentioned this pull request Nov 14, 2023
verification/tagTCI.go Outdated Show resolved Hide resolved
@hpya93
Copy link
Contributor Author

hpya93 commented Nov 16, 2023

Hi @jhand2
Have addressed all comments and updated the conversation(s).
The continuous integration job fails with warning in Rust code.
I could run ci.sh in my machine without issues and all rust/go tests PASS.
Can you please guide?

@jhand2
Copy link
Collaborator

jhand2 commented Nov 17, 2023

Hi @jhand2 Have addressed all comments and updated the conversation(s). The continuous integration job fails with warning in Rust code. I could run ci.sh in my machine without issues and all rust/go tests PASS. Can you please guide?

The issue is that the CI is using a newer Rust toolchain which produces a lot of new clippy errors. This should fix the problem: #258

@hpya93
Copy link
Contributor Author

hpya93 commented Nov 18, 2023

Hi @jhand2 Have addressed all comments and updated the conversation(s). The continuous integration job fails with warning in Rust code. I could run ci.sh in my machine without issues and all rust/go tests PASS. Can you please guide?

The issue is that the CI is using a newer Rust toolchain which produces a lot of new clippy errors. This should fix the problem: #258

Hi @jhand2, I have synced the branch to include your fix, CICD job completes now without issues, Can this be merged?

@jhand2 jhand2 merged commit a1d2ecf into chipsalliance:main Nov 20, 2023
1 check passed
@hpya93 hpya93 deleted the extendtci_support branch November 21, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants