Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common client code and few bug fixes #255

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

hpya93
Copy link
Contributor

@hpya93 hpya93 commented Nov 3, 2023

Hi @jhand2

Have added

  • Files: abi.go, client.go: Code to issue RotateContextHandle, DeriveChild, ExtendTCI and Sign commands
  • File- sign.rs: Bug fix for IS_SYMMETRIC flag in sign.rs file
  • File- sign.rs: Bug fix for DPE error code in sign.rs. It must be "ArgumentNotSupported" instead of "InvalidArgument" when DPE profile does not support a command flag.
  • File - CertifyKey.go, TagTci.go: Bug fix, the context handle created for Simulation mode is not used in code. The contexthandle is stored in variable "handle", but variable "ctx" is used
  • File - InitializeContext.go: Separated out code for simulated context handle creation and put it as a func in InitializeContext.go file. This block was repeated many times.
  • Files - negativeCases.go, simulator.go, verification.go: Added a negativeCases.go - it will test InvalidHandle, wrongLocality, Unsupported DPE command, Unsupported command flags. Tried to address your comment in TagTCI PR by writing a separate function for checking WrongLocality and other negative cases..

When this is merged I shall change other PRs in tune to the main branch with these changes. Kindly let us know the comments.

verification/tagTCI.go Outdated Show resolved Hide resolved
verification/initializeContext.go Outdated Show resolved Hide resolved
verification/initializeContext.go Outdated Show resolved Hide resolved
verification/negativeCases.go Outdated Show resolved Hide resolved
verification/tagTCI.go Outdated Show resolved Hide resolved
verification/verification.go Show resolved Hide resolved
@jhand2 jhand2 merged commit 8e3623d into chipsalliance:main Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants