add mctp userspace lib support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
parvathib
commented
Jan 3, 2025
parvathib
commented
- Adds the MCTP user library API and includes a function in the example_app to test dummy SPDM messages in loopback mode.
- Define a separate instance to the secure SPDM.
- Add Alarm in the Mctp Mux layer to record the message reception time. (This is not propagated to the user yet)
- Pass the test flags to application build to filter out the code execution.
parvathib
requested review from
swenson,
mlvisaya,
mhatrevi,
vsonims and
helloxiling
vsonims
reviewed
Jan 3, 2025
vsonims
reviewed
Jan 3, 2025
| @@ -4,5 +4,5 @@ | |||
|
|
|||
| pub mod flash_partition; | |||
| pub mod mctp_driver; | |||
| pub mod mctp_mux; | |||
| pub mod mock_mctp; | |||
There was a problem hiding this comment.
shouldn't this be under a feature flag to prevent inclusion in release?
There was a problem hiding this comment.
The test code that creates this mock instance (this is under feature flag test-mctp-capsule-loopback) is compiled out in the release builds. The release binary should not have this included.
There was a problem hiding this comment.
I think the module inclusion also needs to be under feature flag
There was a problem hiding this comment.
added it under feature flag
swenson
reviewed
Jan 3, 2025
added 3 commits
January 6, 2025 13:29
swenson
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.