mldsa pcr signing #670
Merged
mldsa pcr signing #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/integration/test_suites/smoke_test_mldsa/smoke_test_mldsa.c
Outdated
Show resolved
Hide resolved
…timestamp and hash after successful run
mojtaba-bisheh
requested review from
upadhyayulakiran,
calebofearth and
Nitsirks
Closed
Nitsirks
reviewed
Jan 3, 2025
…liptra-rtl into mojtaba-mldsa-pcr
…timestamp and hash after successful run
Nitsirks
approved these changes
Jan 6, 2025
calebofearth
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated SHA block to perform SHA512 instead of SHA384 for PCR
Updated KV to use slot 7 for ECC and slot 8 for MLDSA PCR signing
Updated submodule to use MLDSA PCR
Updated pv_hash and_sign to validate the updated PCR signing flow