-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.6] Add PHP 8.3 support #14
Conversation
This issue has been automatically marked as stale because there has been no recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions. |
strftime was deprecated in PHP8.1.0. This is the only PHP8.3.0 compatibility issue detected by the PHPCompatibility scanner git version right now: hans@DESKTOP-EE15SLU:~/projects/PHPCompatibility$ ./vendor/bin/phpcs ../wrench/ --standard=PHPCompatibility FILE: /home/hans/projects/wrench/examples/StatusApplication.php -------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 112 | WARNING | Function strftime() is deprecated since PHP 8.1; Use date() or IntlDateFormatter::format() instead -------------------------------------------------------------------------------------------------------------------- Time: 710ms; Memory: 16MB Related: chrome-php#14 and chrome-php/chrome#605
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/PHPCompatibility/PHPCompatibility detects no relevant PHP8.3 compatibility issues.
LGTM 👍
I don't know how you can say that, when the CI shows that the code is broken on PHP 8.3. |
somehow missed that, sorry. Anyway, made a fix: #20 |
* PHP8.3 compatibility Turns out PHP<8.3's proc_open does not really care if the requested working_dir does not exist, while PHP>=8.3's proc_open bails if it does not exist. And due to a typo in the code, the dir never existed. And due to insufficient error checking, the error was not really detected. Took fking 4 hours to track down, and the fix is 1 byte. divinity76#1 Should probably complain to the php-src bugtracker, i am guessing the proc_open behavior change was unintentional * StyleCI
strftime was deprecated in PHP8.1.0. This is the only PHP8.3.0 compatibility issue detected by the PHPCompatibility scanner git version right now: hans@DESKTOP-EE15SLU:~/projects/PHPCompatibility$ ./vendor/bin/phpcs ../wrench/ --standard=PHPCompatibility FILE: /home/hans/projects/wrench/examples/StatusApplication.php -------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 112 | WARNING | Function strftime() is deprecated since PHP 8.1; Use date() or IntlDateFormatter::format() instead -------------------------------------------------------------------------------------------------------------------- Time: 710ms; Memory: 16MB Related: #14 and chrome-php/chrome#605
No description provided.