Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.6] Add PHP 8.3 support #14

Merged
merged 4 commits into from
Mar 17, 2024
Merged

[1.6] Add PHP 8.3 support #14

merged 4 commits into from
Mar 17, 2024

Commits on Oct 8, 2023

  1. Add PHP 8.3 support

    GrahamCampbell committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    3913bd8 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. PHP8.3 compatibility #2 (#20)

    * PHP8.3 compatibility
    
    Turns out PHP<8.3's proc_open does not really care if the requested working_dir does not exist, while PHP>=8.3's proc_open bails if it does not exist.
    
    And due to a typo in the code, the dir never existed.
    
    And due to insufficient error checking, the error was not really detected.
    
    Took fking 4 hours to track down, and the fix is 1 byte. divinity76#1
    
    Should probably complain to the php-src bugtracker, i am guessing the proc_open behavior change was unintentional
    
    * StyleCI
    divinity76 authored Mar 17, 2024
    Configuration menu
    Copy the full SHA
    3f4b1f7 View commit details
    Browse the repository at this point in the history
  2. Apply fixes from StyleCI

    StyleCIBot committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    070bba2 View commit details
    Browse the repository at this point in the history
  3. PHP8.3 compatibility (#18)

    strftime was deprecated in PHP8.1.0.
    This is the only PHP8.3.0 compatibility issue detected by the PHPCompatibility scanner git version right now:
    
    hans@DESKTOP-EE15SLU:~/projects/PHPCompatibility$ ./vendor/bin/phpcs ../wrench/ --standard=PHPCompatibility
    
    FILE: /home/hans/projects/wrench/examples/StatusApplication.php
    --------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------------
     112 | WARNING | Function strftime() is deprecated since PHP 8.1; Use date() or IntlDateFormatter::format() instead
    --------------------------------------------------------------------------------------------------------------------
    
    Time: 710ms; Memory: 16MB
    
    Related: #14 and chrome-php/chrome#605
    divinity76 authored Mar 17, 2024
    Configuration menu
    Copy the full SHA
    2ebf257 View commit details
    Browse the repository at this point in the history