PHP8.3 compatibility #2 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out PHP<8.3's proc_open does not really care if the requested working_dir does not exist, while PHP>=8.3's proc_open bails if it does not exist. And due to a typo in the code, the dir never existed. And due to insufficient error checking, the error was not really detected. Took fking 4 hours to track down, and the fix is 1 byte. #1 Should probably complain to the php-src bugtracker, i am guessing the proc_open behavior change was unintentional
|
Thanks for digging into this. 🎉 |
This was referenced Mar 17, 2024
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out PHP<8.3's proc_open does not really care if the requested working_dir does not exist, while PHP>=8.3's proc_open bails if it does not exist.
And due to a typo in the code, the dir never existed.
And due to insufficient error checking, the error was not really detected.
Took fking 4 hours to track down: divinity76#1
, and the fix is 1 byte 🤦♂️
Should probably complain to the php-src bugtracker, i am guessing the proc_open behavior change was unintentional (should at least be a E_DEPRECATED period "picking a non-existing working dir is deprecated and will stop working in a future version of PHP")