New Common Controls policy for Early Access App Access controls #371

jkaufman-mitre · 2024-08-29T14:24:17Z

🗣 Description

Added Policy Group 18 to Common Controls Baseline for Early Access Apps

Code changes tracked in #402.

💭 Motivation and context

Closes #370

Google Product Update

🧪 Testing

N/A, this PR does not add any new code

✅ Pre-approval checklist

This PR has an informative and human-readable title.
Changes are limited to a single goal - eschew scope creep!
If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
The relevant issues PR resolves are linked preferably via closing keywords.
All relevant type-of-change labels have been added.
I have read and agree to the CONTRIBUTING.md document.
These code changes follow cisagov code standards.
All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

✅ Pre-merge Checklist

This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

Delete the branch to clean up.
Close issues resolved by this PR if the closing keywords did not activate.

buidav

initial comments

baselines/commoncontrols.md

adhilto

I agree with David's comments. One more thing to consider:

baselines/commoncontrols.md

Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]>

…/github.com/cisagov/ScubaGoggles into 370-early-access-app-access-common-controls

baselines/commoncontrols.md

drift-rules/GWS Drift Monitoring Rules - Common Controls as of 11-14-23.csv

baselines/commoncontrols.md

Co-authored-by: David Bui <[email protected]>

baselines/commoncontrols.md

Co-authored-by: David Bui <[email protected]>

* Added Policy Group 18 * Added Drift Rule for Policy Group 18 * Fixed Table of Contents * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> * Fixed Implementation * Added Policy Under Policy Group 16 * Fixed Policy Group 16 Intro * Changed Security to Secure in header * Fixed TOC * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> * Fixed drift rule files * Update baselines/commoncontrols.md Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> Co-authored-by: mdueltgen <[email protected]>

* Updated Resource Link for DriveDocs 3.1 (#400) * Fixes Numbering Issue in GMAIL 5.3 Instructions (#399) * Fixed numbering issue in instruction for 5.3 * Update baselines/gmail.md End with a period for automation processing reasons. Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * Updating Classroom 1.2 Instructions (#407) * New Common Controls policy for Early Access App Access controls (#371) * Added Policy Group 18 * Added Drift Rule for Policy Group 18 * Fixed Table of Contents * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> * Fixed Implementation * Added Policy Under Policy Group 16 * Fixed Policy Group 16 Intro * Changed Security to Secure in header * Fixed TOC * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> * Fixed drift rule files * Update baselines/commoncontrols.md Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> Co-authored-by: mdueltgen <[email protected]> * Updated Location of Setting in DriveDocs 6.1 Instructions (#404) * Updated location of setting in instructions and fixed bolding * Update baselines/drive.md Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * Updating Common Controls 11.2 Implementation Instructions #375 (#411) * updated location of setting in implementation instructions * adding in periods * Update baselines/commoncontrols.md Co-authored-by: David Bui <[email protected]> * Update baselines/commoncontrols.md removed extra period Co-authored-by: David Bui <[email protected]> * Remove double period in overview --------- Co-authored-by: David Bui <[email protected]> * Updating Common Controls 12.1 Implementation Steps (#414) * Updated location for takeout admin control based on update to data tab in admin console * Update baselines/commoncontrols.md Fixes capitalization of import/export per admin console Co-authored-by: Alden Hilton <[email protected]> * removing unnecessary save step --------- Co-authored-by: Alden Hilton <[email protected]> * Update location of rules setting in admin console in implementation steps. (#418) * Updating Common Controls 15.1 Implementation Steps (#420) * udpated location of setting for data regions in instructions * Update baselines/commoncontrols.md removed S in compliances Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * Fixed backslashes/forwardslashes bug in Common Controls Baseline (#426) * Changed Early Access to Early Access Apps (#428) * Add Data at Rest processing policy to Common Controls baseline (#434) * Added Policy 15.2 and renamed previous 15.2 to 15.3 * adding drift rule for 15.2 * Added TTP Mappings * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Update drift-rules/GWS Drift Monitoring Rules - Common Controls as of 11-14-23.csv Co-authored-by: Alden Hilton <[email protected]> * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: mdueltgen <[email protected]> Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> * updating implementation steps for 13.1 to clarify editting rules * fixed numbering and removed old language about having to click show more which doesn't exist anymore in the admin consle. * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Update baselines/commoncontrols.md Co-authored-by: Alden Hilton <[email protected]> --------- Co-authored-by: David Bui <[email protected]> Co-authored-by: jkaufman-mitre <[email protected]> Co-authored-by: Alden Hilton <[email protected]>

* Added Policy Group 18 * Added Drift Rule for Policy Group 18 * Fixed Table of Contents * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> * Fixed Implementation * Added Policy Under Policy Group 16 * Fixed Policy Group 16 Intro * Changed Security to Secure in header * Fixed TOC * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> * Fixed drift rule files * Update baselines/commoncontrols.md Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> Co-authored-by: mdueltgen <[email protected]>

* Updated Resource Link for DriveDocs 3.1 (#400) * Fixes Numbering Issue in GMAIL 5.3 Instructions (#399) * Fixed numbering issue in instruction for 5.3 * Update baselines/gmail.md End with a period for automation processing reasons. Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * Updating Classroom 1.2 Instructions (#407) * New Common Controls policy for Early Access App Access controls (#371) * Added Policy Group 18 * Added Drift Rule for Policy Group 18 * Fixed Table of Contents * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> * Fixed Implementation * Added Policy Under Policy Group 16 * Fixed Policy Group 16 Intro * Changed Security to Secure in header * Fixed TOC * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> * Fixed drift rule files * Update baselines/commoncontrols.md Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> Co-authored-by: mdueltgen <[email protected]> * Updated Location of Setting in DriveDocs 6.1 Instructions (#404) * Updated location of setting in instructions and fixed bolding * Update baselines/drive.md Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * Updating Common Controls 11.2 Implementation Instructions #375 (#411) * updated location of setting in implementation instructions * adding in periods * Update baselines/commoncontrols.md Co-authored-by: David Bui <[email protected]> * Update baselines/commoncontrols.md removed extra period Co-authored-by: David Bui <[email protected]> * Remove double period in overview --------- Co-authored-by: David Bui <[email protected]> * Updating Common Controls 12.1 Implementation Steps (#414) * Updated location for takeout admin control based on update to data tab in admin console * Update baselines/commoncontrols.md Fixes capitalization of import/export per admin console Co-authored-by: Alden Hilton <[email protected]> * removing unnecessary save step --------- Co-authored-by: Alden Hilton <[email protected]> * Update location of rules setting in admin console in implementation steps. (#418) * Updating Common Controls 15.1 Implementation Steps (#420) * udpated location of setting for data regions in instructions * Update baselines/commoncontrols.md removed S in compliances Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * Fixed backslashes/forwardslashes bug in Common Controls Baseline (#426) * Changed Early Access to Early Access Apps (#428) * Add Data at Rest processing policy to Common Controls baseline (#434) * Added Policy 15.2 and renamed previous 15.2 to 15.3 * adding drift rule for 15.2 * Added TTP Mappings * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Update drift-rules/GWS Drift Monitoring Rules - Common Controls as of 11-14-23.csv Co-authored-by: Alden Hilton <[email protected]> * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: mdueltgen <[email protected]> Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> * updating implementation steps for 13.1 to clarify editting rules * fixed numbering and removed old language about having to click show more which doesn't exist anymore in the admin consle. * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Update baselines/commoncontrols.md Co-authored-by: Alden Hilton <[email protected]> --------- Co-authored-by: David Bui <[email protected]> Co-authored-by: jkaufman-mitre <[email protected]> Co-authored-by: Alden Hilton <[email protected]>

* Updated Resource Link for DriveDocs 3.1 (#400) * Fixes Numbering Issue in GMAIL 5.3 Instructions (#399) * Fixed numbering issue in instruction for 5.3 * Update baselines/gmail.md End with a period for automation processing reasons. Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * New Common Controls policy for Early Access App Access controls (#371) * Added Policy Group 18 * Added Drift Rule for Policy Group 18 * Fixed Table of Contents * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> * Fixed Implementation * Added Policy Under Policy Group 16 * Fixed Policy Group 16 Intro * Changed Security to Secure in header * Fixed TOC * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> * Fixed drift rule files * Update baselines/commoncontrols.md Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> Co-authored-by: mdueltgen <[email protected]> * Updated Location of Setting in DriveDocs 6.1 Instructions (#404) * Updated location of setting in instructions and fixed bolding * Update baselines/drive.md Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * Updating Common Controls 11.2 Implementation Instructions #375 (#411) * updated location of setting in implementation instructions * adding in periods * Update baselines/commoncontrols.md Co-authored-by: David Bui <[email protected]> * Update baselines/commoncontrols.md removed extra period Co-authored-by: David Bui <[email protected]> * Remove double period in overview --------- Co-authored-by: David Bui <[email protected]> * Updating Common Controls 12.1 Implementation Steps (#414) * Updated location for takeout admin control based on update to data tab in admin console * Update baselines/commoncontrols.md Fixes capitalization of import/export per admin console Co-authored-by: Alden Hilton <[email protected]> * removing unnecessary save step --------- Co-authored-by: Alden Hilton <[email protected]> * Update location of rules setting in admin console in implementation steps. (#418) * Updating Common Controls 15.1 Implementation Steps (#420) * udpated location of setting for data regions in instructions * Update baselines/commoncontrols.md removed S in compliances Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * Fixed backslashes/forwardslashes bug in Common Controls Baseline (#426) * Changed Early Access to Early Access Apps (#428) * Add Data at Rest processing policy to Common Controls baseline (#434) * Added Policy 15.2 and renamed previous 15.2 to 15.3 * adding drift rule for 15.2 * Added TTP Mappings * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Update drift-rules/GWS Drift Monitoring Rules - Common Controls as of 11-14-23.csv Co-authored-by: Alden Hilton <[email protected]> * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: mdueltgen <[email protected]> Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> * Clarifying Implementation Steps of CommonControls13.1 (#445) * Updated Resource Link for DriveDocs 3.1 (#400) * Fixes Numbering Issue in GMAIL 5.3 Instructions (#399) * Fixed numbering issue in instruction for 5.3 * Update baselines/gmail.md End with a period for automation processing reasons. Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * Updating Classroom 1.2 Instructions (#407) * New Common Controls policy for Early Access App Access controls (#371) * Added Policy Group 18 * Added Drift Rule for Policy Group 18 * Fixed Table of Contents * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> * Fixed Implementation * Added Policy Under Policy Group 16 * Fixed Policy Group 16 Intro * Changed Security to Secure in header * Fixed TOC * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> * Fixed drift rule files * Update baselines/commoncontrols.md Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> Co-authored-by: mdueltgen <[email protected]> * Updated Location of Setting in DriveDocs 6.1 Instructions (#404) * Updated location of setting in instructions and fixed bolding * Update baselines/drive.md Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * Updating Common Controls 11.2 Implementation Instructions #375 (#411) * updated location of setting in implementation instructions * adding in periods * Update baselines/commoncontrols.md Co-authored-by: David Bui <[email protected]> * Update baselines/commoncontrols.md removed extra period Co-authored-by: David Bui <[email protected]> * Remove double period in overview --------- Co-authored-by: David Bui <[email protected]> * Updating Common Controls 12.1 Implementation Steps (#414) * Updated location for takeout admin control based on update to data tab in admin console * Update baselines/commoncontrols.md Fixes capitalization of import/export per admin console Co-authored-by: Alden Hilton <[email protected]> * removing unnecessary save step --------- Co-authored-by: Alden Hilton <[email protected]> * Update location of rules setting in admin console in implementation steps. (#418) * Updating Common Controls 15.1 Implementation Steps (#420) * udpated location of setting for data regions in instructions * Update baselines/commoncontrols.md removed S in compliances Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> * Fixed backslashes/forwardslashes bug in Common Controls Baseline (#426) * Changed Early Access to Early Access Apps (#428) * Add Data at Rest processing policy to Common Controls baseline (#434) * Added Policy 15.2 and renamed previous 15.2 to 15.3 * adding drift rule for 15.2 * Added TTP Mappings * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Update drift-rules/GWS Drift Monitoring Rules - Common Controls as of 11-14-23.csv Co-authored-by: Alden Hilton <[email protected]> * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: mdueltgen <[email protected]> Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]> * updating implementation steps for 13.1 to clarify editting rules * fixed numbering and removed old language about having to click show more which doesn't exist anymore in the admin consle. * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * Update baselines/commoncontrols.md Co-authored-by: Alden Hilton <[email protected]> --------- Co-authored-by: David Bui <[email protected]> Co-authored-by: jkaufman-mitre <[email protected]> Co-authored-by: Alden Hilton <[email protected]> * first draft of new DLP changes * TOC update, group description, clarifying implementation steps * removing extra spacing * first draft of new DLP changes * TOC update, group description, clarifying implementation steps * removing extra spacing * updating drift rules * updating implemetnation steps for actions, adding should block external sharing policy * draft for condition rules for Credit card/ITIN/SSN * updated TOC for chat/drive * adding in drift rules * Apply suggestions from code review Co-authored-by: Alden Hilton <[email protected]> * code changes based on comments * code changes udpating implementation steps across policy group 18 * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> Co-authored-by: Alden Hilton <[email protected]> * replacing add instead of actions * Apply suggestions from code review Parity w/ m365 and scubagear 3rd party DLP options license info Co-authored-by: David Bui <[email protected]> * updating TOC * Apply suggestions from code review Co-authored-by: David Bui <[email protected]> --------- Co-authored-by: David Bui <[email protected]> Co-authored-by: jkaufman-mitre <[email protected]> Co-authored-by: Alden Hilton <[email protected]>

jkaufman-mitre added 2 commits August 29, 2024 10:21

Added Policy Group 18

01720dc

Added Drift Rule for Policy Group 18

259d18f

jkaufman-mitre added Baseline Revision High Code Changes Required labels Aug 29, 2024

jkaufman-mitre requested review from LaurenBassett, buidav, adhilto and mdueltgen August 29, 2024 14:24

jkaufman-mitre self-assigned this Aug 29, 2024

Fixed Table of Contents

17be053

mdueltgen added this to the Driftwood milestone Aug 29, 2024

mdueltgen added the Common Controls label Aug 29, 2024

buidav requested changes Aug 29, 2024

View reviewed changes

baselines/commoncontrols.md Outdated Show resolved Hide resolved

baselines/commoncontrols.md Outdated Show resolved Hide resolved

baselines/commoncontrols.md Outdated Show resolved Hide resolved

buidav temporarily deployed to Development August 29, 2024 17:07 — with GitHub Actions Inactive

adhilto requested changes Aug 29, 2024

View reviewed changes

baselines/commoncontrols.md Outdated Show resolved Hide resolved

adhilto temporarily deployed to Development August 29, 2024 17:14 — with GitHub Actions Inactive

jkaufman-mitre and others added 4 commits August 30, 2024 07:08

Apply suggestions from code review

703beff

Co-authored-by: Alden Hilton <[email protected]> Co-authored-by: David Bui <[email protected]>

Fixed Implementation

d5a879e

Merge branch '370-early-access-app-access-common-controls' of https:/…

9842113

…/github.com/cisagov/ScubaGoggles into 370-early-access-app-access-common-controls

Added Policy Under Policy Group 16

5b394a7

jkaufman-mitre temporarily deployed to Development August 30, 2024 11:14 — with GitHub Actions Inactive

jkaufman-mitre temporarily deployed to Development September 4, 2024 14:12 — with GitHub Actions Inactive

jkaufman-mitre mentioned this pull request Sep 4, 2024

Changed Security to Secure in Reference to Secure Configuration Baselines #384

Closed

buidav requested changes Sep 5, 2024

View reviewed changes

buidav temporarily deployed to Development September 5, 2024 03:34 — with GitHub Actions Inactive

jkaufman-mitre mentioned this pull request Sep 5, 2024

Switched Security to Secure Across All Baselines #389

Merged

jkaufman-mitre and others added 2 commits September 5, 2024 06:27

Apply suggestions from code review

65f54b0

Co-authored-by: David Bui <[email protected]>

Fixed drift rule files

e23f5a8

mdueltgen requested review from buidav and adhilto September 12, 2024 15:23

adhilto approved these changes Sep 12, 2024

View reviewed changes

mdueltgen self-assigned this Sep 12, 2024

mdueltgen removed their request for review September 12, 2024 17:35

adhilto mentioned this pull request Sep 12, 2024

Implement new Common Controls early access control #402

Closed

1 task

buidav changed the title ~~370 early access app access common controls~~ New Common Controls policy for Early Access App Access controls Sep 16, 2024

buidav requested changes Sep 16, 2024

View reviewed changes

baselines/commoncontrols.md Outdated Show resolved Hide resolved

Update baselines/commoncontrols.md

18dc940

Co-authored-by: David Bui <[email protected]>

mdueltgen requested a review from buidav September 17, 2024 15:59

buidav approved these changes Sep 17, 2024

View reviewed changes

buidav merged commit ea23ae5 into driftwood Sep 17, 2024
2 checks passed

buidav deleted the 370-early-access-app-access-common-controls branch September 17, 2024 17:08

buidav mentioned this pull request Sep 17, 2024

Early Access App Access Common Controls #370

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Common Controls policy for Early Access App Access controls #371

New Common Controls policy for Early Access App Access controls #371

jkaufman-mitre commented Aug 29, 2024 •

edited by buidav

Loading

buidav left a comment

adhilto left a comment

New Common Controls policy for Early Access App Access controls #371

New Common Controls policy for Early Access App Access controls #371

Conversation

jkaufman-mitre commented Aug 29, 2024 • edited by buidav Loading

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

✅ Pre-merge Checklist

✅ Post-merge Checklist

buidav left a comment

Choose a reason for hiding this comment

adhilto left a comment

Choose a reason for hiding this comment

jkaufman-mitre commented Aug 29, 2024 •

edited by buidav

Loading