Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON Lint Issues. #49

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Mar 13, 2024

🗣 Description

Apply pretty-format-json to all *.json files.
Change censysCertificatesSample.json and censysIpv4Sample.json to *.txt file type.

💭 Motivation and context

Closes issue #48
The Censys sample data json files are not true json. They are line-separated json objects vs an array of json objects. As such, they get flagged by both pretty-format-json and check-json. Converting each file to a properly formatted json array requires refactoring the test suites that use them. For expedience, I converted them to *.txt files.

🧪 Testing

Existing tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson linked an issue Mar 13, 2024 that may be closed by this pull request
2 tasks
@Matthew-Grayson Matthew-Grayson self-assigned this Mar 13, 2024
@Matthew-Grayson Matthew-Grayson changed the title Fix issues flagged by pretty-format-json. Fix JSON Lint Issues. Mar 13, 2024
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed json linting fixed.

Copy link
Contributor

@DJensen94 DJensen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 8fe2660 into develop Mar 19, 2024
13 of 17 checks passed
@dav3r dav3r mentioned this pull request Mar 20, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Lint Issues Related to JSON Files
3 participants