Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored Skip to Main Content functionality (CRASM-630) #590

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

hawkishpolicy
Copy link
Collaborator

  • Restored "Skip to Main Content" functionality.

🗣 Description

  • Added the "main-content" id to the Box div inside of Main.
  • Set the tabIndex to -1 for the Box div inside of Main.

💭 Motivation and context

  • The refactor of Layout following the creation of the new Side Drawer removed the functionality of the "Skip to Main Content" component.
  • The restoration of the "main-content" id and -1 tabIndex restores this functionality.
  • Closes CRASM-630
  • Closes Skip To Main Content Not Working (CRASM-630) #589

🧪 Testing

📷 Screenshots (if appropriate)

Screenshot 2024-09-05 at 12 56 03 PM
Screenshot 2024-09-05 at 12 56 15 PM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

- Added the "main-content" id to the Box div inside of Main.
- Set the tabIndex to -1 for the Box div inside of Main.
@hawkishpolicy hawkishpolicy self-assigned this Sep 5, 2024
@hawkishpolicy hawkishpolicy linked an issue Sep 5, 2024 that may be closed by this pull request
Copy link
Collaborator

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 6ac5b6c into develop Sep 6, 2024
11 of 15 checks passed
@schmelz21 schmelz21 deleted the 589-skip-to-main-content-not-working-crasm-630 branch September 6, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip To Main Content Not Working (CRASM-630)
5 participants