Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow assumption of the Users account provision role #30

Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 18, 2024

🗣 Description

This pull request modified the Terraform code to allow COOL assessment provisioners to also assume the Users account provision role.

See also cisagov/cool-assessment-terraform#254.

💭 Motivation and context

This is necessary due to the changes in cisagov/cool-assessment-terraform#254.

🧪 Testing

All automated tests pass. I also deployed these changes to our COOL Users account and verified as part of the testing for cisagov/cool-assessment-terraform#254 that they function as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use terraform Pull requests that update Terraform code hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation labels Oct 18, 2024
@jsf9k jsf9k self-assigned this Oct 18, 2024
@jsf9k jsf9k marked this pull request as ready for review October 18, 2024 15:52
@jsf9k jsf9k requested a review from a team October 18, 2024 15:52
@jsf9k jsf9k enabled auto-merge October 18, 2024 15:52
@jsf9k jsf9k merged commit 91b6ce0 into develop Oct 18, 2024
4 checks passed
@jsf9k jsf9k deleted the improvement/allow-assumption-of-users-account-provision-role branch October 18, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use terraform Pull requests that update Terraform code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants