-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach policy to specified users allowing assumption of the Terraform state read-write role #254
Attach policy to specified users allowing assumption of the Terraform state read-write role #254
Conversation
…e read-write role
This is necessary due to the changes in cisagov/cool-assessment-terraform#254.
900f20c
to
fa03a79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, other than the one missing word that I noted. 👍
After further reflection, I think that the two markdown files that you added don't belong in this repo. The info from those files should be passed to our Ops team and users so that it can be stored wherever they keep their various runbooks. |
83a861a
to
c20fff1
Compare
Those commits have been removed and I have emailed the information to the relevant parties. |
🗣 Description
This pull request attaches a policy to specified users allowing assumption of the Terraform state read-write role. It also adds:
See also cisagov/cool-assessment-provisioner-iam#30.
💭 Motivation and context
It is better to attach the policy in Terraform instead of requiring operations to do so manually in the AWS console.
🧪 Testing
All automated tests pass. I deployed these changes to
env6
in our COOL staging environment and verified that they function as expected.✅ Pre-approval checklist