React upgrade Part 2 #2093
Merged
React upgrade Part 2 #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files to support react 18
…t 18 and replaced with '@mui/system'
…ncy upgrade changes
|
We are getting there! I ran the tests with npm test -- -u and they all passed. The tests will need to be updated to use React 18 as another part of this effort coming up. Below shows how some of the styling has changed. These will need to be fixed before we can merge into master. 
|
…asses' imported from 'classnames'
…crossfeed into vr/testing_branch_react_upgrade
…o vr/testing_branch_react_upgrade
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ValeriaReveles
force-pushed
the
vr/testing_branch_react_upgrade
branch
from
d196e72
to
7f8d1f3
Compare
actualeyes
approved these changes
Aug 9, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React upgrade Part 2
🗣 Description
Refactored code on frontend "components", "pages", and "context" .tsx files in order to support React 18 upgrade to Crossfeed.
💭 Motivation and context
The current version of React (^17.0.0) is out of date which can lead to issues with future maintenance and operability of the Crossfeed site. Additionally, certain components and libraries such as MUI v5 no longer support React 17 and below making migration to React 18 necessary.
Issues with old '@mui/styles' components addressed and updated to support new "@mui/material/styles' needed. Changes needed addressed with "Material UI JSS to Emotion migration" documentation.
This PR closses issue #2065.
🧪 Testing
Tested using existing tests on Crossfeed project through 'npm test'. Passed all build checks and able to compile successfully.
However, new tests and QA procedures will need to be created to address new changes and upgrades.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist