Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a post-deployment Ansible provisioner for the BOD bastion #699

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Add a post-deployment Ansible provisioner for the BOD bastion #699

merged 1 commit into from
Oct 19, 2023

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Oct 17, 2023 •
edited
Loading

🗣 Description

This pull request adds a post-deployment Ansible provisioner for the BOD bastion.

💭 Motivation and context

This ensures that all of our EC2 instances are configured with an Ansible provisioner for post-deployment configuration needs. Although there is nothing specifically needed for the BOD bastion (the groups Ansible role will be run against it now) it ensures that the scaffolding exists for any future needs.

🧪 Testing

Automated tests pass. I was able to successfully deploy a new BOD bastion in my test environment and had no issues with functionality.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj
Add an Ansible provisioner for the bod bastion
58c4b27 
This ensures that all instance types are being deployed in a consistent
manner. Although nothing should really be done to the bod bastion with
our current Ansible playbook for the post-deployment provisioner; this
will ensure any future changes for all hosts apply.
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation terraform Pull requests that update Terraform code labels Oct 17, 2023
@mcdonnnj mcdonnnj self-assigned this Oct 17, 2023
dav3r
dav3r approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I noted one tiny thang.

terraform/bod_bastion_ec2.tf Show resolved Hide resolved
@mcdonnnj mcdonnnj merged commit abb369c into develop Oct 19, 2023
@mcdonnnj mcdonnnj deleted the improvement/add_ansible_provisioner_for_bod_bastion branch October 19, 2023 13:45
@mcdonnnj mcdonnnj mentioned this pull request Oct 19, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@mcdonnnj mcdonnnj

Labels
hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use terraform Pull requests that update Terraform code
Projects
CyHy System
Status: Done
Cyber Hygiene (CyHy)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r