-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design review: Analyst Portfolio view #2402
Comments
may be done in sprint 51 or 50. CC: @Katherine-Osos on this |
@abroddrick to identify which issues block this review |
Leaving refinement on here, in case our experience with the m1 and m2 reviews indicates a need to update this. |
Moving to 54 given I just added a quick fix to it, though this could be brought into 53, if the quick fix is dealt with quickly. CC: @Katherine-Osos and @witha-c |
No adjustments needed on design review ticket template based on first design review ticket. |
@Katherine-Osos, Zander is your |
#2402: Design Review for Analyst Portfolio View - [ZA] - MIGRATION
Issue description
As the analyst view for the portfolio is all set in django admin, we just had mockups of what the admin view may look like and then attempted to follow it. All tickets for making this portfolio view have also not gone through design review. Thus, we need design to review this feature when it is ready in getgov-development and to suggest any changes desired. If no changes at all are desired at the moment, we would consider this feature complete for now.
Note the django admin tables to look at should be:
note for the last 3 we haven't changed more than adding in portfolio and suborg. I expect we should hide more fields for org model domains/requests than are shown currently.
Acceptance criteria
Additional context
Working with dev: Dev effort on this shouldn't be more than a "2" (2 full work days).
NOTE: This design review does not include testing permissions and/or sending emails. That will be tested separately once that work is implemented.
Links to other issues
The text was updated successfully, but these errors were encountered: