Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CONFLICT! Lineage pull request for: skeleton #19

Merged
merged 142 commits into from
May 13, 2024
Merged

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Sep 13, 2023

Lineage Pull Request: CONFLICT

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-generic.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone [email protected]:cisagov/skeleton-aws-lambda-python.git skeleton-aws-lambda-python
    cd skeleton-aws-lambda-python
    git remote add skeleton https://github.com/cisagov/skeleton-generic.git
    git remote set-url --push skeleton no_push
    git switch develop
    git switch --create lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the
    branch, commit, and push your changes:

    git add .github/dependabot.yml 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message
    that git creates for you, but please do not delete the existing
    content
    . It provides useful information about the merge that is
    being performed.

  5. Wait for all the automated tests to pass.

  6. Confirm each item in the "Pre-approval checklist" below.

  7. Remove any of the checklist items that do not apply.

  8. Ensure every remaining checkbox has been checked.

  9. Mark this draft pull request "Ready for review".

✅ Pre-approval checklist

Remove any of the following that do not apply. If you're unsure about
any of these, don't hesitate to ask. We're here to help!

  • ✌️ The conflicts in this pull request have been resolved.
  • All relevant type-of-change labels have been added.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

Note

You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

jasonodoom and others added 30 commits July 10, 2023 12:52
This is being done for testing purposes, and this commit can be
reverted (or removed) once cisagov/setup-env-github-action#65 is
merged.
The repo name we were using redirects to the correct place, but we may
as well cut out the middle man.
Co-authored-by: Shane Frasier <[email protected]>
We generally only use quotes when they are strictly necessary to ensure
data is interpreted as a string value.
Our standard practice for YAML files is to sort keys alphabetically.
Co-authored-by: David Harris <[email protected]>
…b-action"

This reverts commit ddbf6f7.

This can be done now that cisagov/setup-env-github-action#65 has been
merged.
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Add crazy-max/ghaction-github-labeler as a commented out dependency to
ignore in the dependabot configuration file. This should be enabled in
downstream projects to consolidate updating this Action to the
cisagov/skeleton-generic repository.
Use the correct repo name for the ansible-lint pre-commit hook
…nfiguration

Update the Dependabot configuration
…s/checkout-4

Bump actions/checkout from 3 to 4
…ok_for_shellcheck

Switch the pre-commit hook used to run `shellcheck`
Add a leading "# " to the existing attribution comment for the
dependency managed by this project. This is consistent with how it is
done in other skeleton projects.
This is consistent with changes made in the upstream project.
Since this should be done in every job in our GitHub Actions workflow
it needed to be added to the `test` and `build` jobs.
Use the Python version defined in cisagov/setup-env-github-action in
the `test` job. This is consistent with changes made upstream.
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code labels May 8, 2024
This updates the `build` and `test` jobs to match the `lint` job.
This updates the `test` job to match the `lint` job.
This matches the version used in the `build` workflow's jobs.
@mcdonnnj mcdonnnj added documentation This issue or pull request improves or adds to documentation dependencies Pull requests that update a dependency file labels May 10, 2024
@mcdonnnj mcdonnnj marked this pull request as ready for review May 10, 2024 20:23
@mcdonnnj mcdonnnj mentioned this pull request May 10, 2024
6 tasks
@mcdonnnj mcdonnnj added this pull request to the merge queue May 13, 2024
Merged via the queue into develop with commit d61d55b May 13, 2024
15 checks passed
@mcdonnnj mcdonnnj deleted the lineage/skeleton branch May 13, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation This issue or pull request improves or adds to documentation github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use upstream update This issue or pull request pulls in upstream updates
Projects
Development

Successfully merging this pull request may close these issues.

7 participants