[REF] Standalone System - graduate some functions from Civi\Standalone\Security to CRM_Utils_System_Standalone and Civi\Authx\Standalone

[ufundo]

Overview

Attempt at consolidating some of the functions in CRM_Utils_System_Standalone , Civi\Standalone\Security and Civi\Authx\Standalone .

Before

• Many of the functions for CRM_Utils_System_Standalone are implemented in Civi\Standalone\Security
• Piecemeal handling in the CRM_Utils_System_Standalone for when standaloneusers extension is unavailable

After

• System functions that it seems unlikely the user extension would want to change moved to the System class
• \Civi\Standalone\Security keeps the juicy password algorithm logic
• a reusable check for whether standaloneusers and authx are available, and more failsafes when not

Comments

I've edited to break out some of the more functional changes.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[ufundo]

Have narrowed this PR to take out:

• parts path parts covered by Standalone System - bring default Civi::paths factories in line with installer defaults #31150
• authx/authenticate change commented above, will make a separate PR

[colemanw]

Code looks good. IMO better to merge it now while Standalone is still in beta.

[ufundo]

Thanks @colemanw

There's a couple new merge conflicts that need working through, so switching to nearly-merge-ready just for the minute 🙂

[ufundo]

Hmm - I think this is now failing as a symptom of https://lab.civicrm.org/dev/core/-/issues/5493 - ActionObjectProvider::getEntities is getting a bit tied in knots during install as well as upgrade.

[ufundo]

@colemanw this is rebased and passing again - I think it's good to go 👍

[colemanw]

Nice work @ufundo