Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment.yml files per directory #43

Merged
merged 13 commits into from
Sep 1, 2023
Merged

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Aug 25, 2023

Change list

  • Create an environment.yml file per directory containing the conda packages required for that notebook to run. To me this seems more maintainable than trying to include every dependency in one or two environment files, and seems more straightforward for users: "use the linked environment for each notebook"

I went through and ran each notebook in each directory, verifying that they ran for me with these sets of dependencies.

Closes https://github.com/developmentseed/cloud-optimized-geospatial-formats-guide/issues/20

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://developmentseed.github.io/cloud-optimized-geospatial-formats-guide/pr-preview/pr-43/
on branch gh-pages at 2023-08-25 19:51 UTC

Comment on lines +14 to +18
# This is a hack to install pyarrow via pip because libgdal-arrow-parquet constrains libarrow to
# v10, which constrains pyarrow to v10, which is too old for the `filesystem` parameter at the end
# of the file
- pip:
- pyarrow
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hack should be able to be removed after conda-forge/gdal-feedstock#796 is merged

@abarciauskas-bgse
Copy link
Contributor

Thanks @kylebarron I don't think I'm going to go through and test myself today but so far this looks good. It looks like this branch is behind main though, I was looking to add instructions about having conda or mamba installed in https://github.com/developmentseed/cloud-optimized-geospatial-formats-guide/blob/main/index.qmd#L14-L18 or contributing.md

@kylebarron
Copy link
Member Author

I added a sentence in the contributing docs that we expect an environment.yml file with each notebook, and a paragraph in index.qmd linking to Conda and Mamba for installing the environment.

@kylebarron kylebarron merged commit 503ce79 into main Sep 1, 2023
1 check passed
@kylebarron kylebarron deleted the kyle/environments branch September 18, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide environment instructions
2 participants