fix: deprecate OnFormUpdate hook
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime1992
added
scope: doc
If you patch your form and update a few values, this hook will be called multiple times: 1 time for each updated value. Which is not ideal. Also has a bug here #127 And I've given more details here: #86 (comment)
maxime1992
force-pushed
the
fix/deprecate-on-form-update-hook
branch
from
b06a06b
to
aa3c9a7
Compare
zakhenry
approved these changes
Feb 11, 2020
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you patch your form and update a few values, this hook will be called multiple times: 1 time for each updated value. Which is not ideal.
Also has a bug here #127
And I've given more details here: #86 (comment)