feat: Use a centralized announcer to make aria-live announcements #8135
avinashbotbuild-lint-test.yml
on: pull_request
build
/
git-secrets
5s
build
/
build
6m 41s
build
/
codeql
2m 16s
git-secrets
4s
deploy
/
deploy
Annotations
10 errors and 11 warnings
|
Code editor component › sends annotation text to LiveRegion Component for a11y announcement:
src/code-editor/__tests__/code-editor.test.tsx#L367
expect(received).toContain(expected) // indexOf
Matcher error: received value must not be null nor undefined
Received has value: undefined
at Object.<anonymous> (src/code-editor/__tests__/code-editor.test.tsx:367:24)
|
|
Tag Editor component › should render itemRemovedAriaLive when a tag is removed:
src/tag-editor/__tests__/tag-editor.test.tsx#L389
TypeError: Cannot read properties of null (reading 'getElement')
Ignored nodes: comments, script, style
<html>
<head />
<body>
<div
class="awsui_announcer_3bgfn_7vh5v_103"
/>
<div
class="awsui_announcer_3bgfn_7vh5v_103"
/>
<div>
<div
class="awsui_root_brdst_t5572_99 awsui_root_n4qlp_dxsjy_125"
>
<div
class="awsui_root_18wu0_zm72j_99 awsui_box_18wu0_zm72j_219 awsui_m-bottom-l_18wu0_zm72j_951 awsui_color-default_18wu0_zm72j_219 awsui_font-size-default_18wu0_zm72j_235 awsui_font-weight-default_18wu0_zm72j_275"
>
<div
class="awsui_row_n4qlp_dxsjy_167 awsui_root_18wu0_zm72j_99 awsui_box_18wu0_zm72j_219 awsui_m-bottom-s_18wu0_zm72j_901 awsui_color-default_18wu0_zm72j_219 awsui_font-size-default_18wu0_zm72j_235 awsui_font-weight-default_18wu0_zm72j_275"
>
<div
aria-labelledby="first-control-id-558-1712660564080-2853-label first-control-id-558-1712660564080-2853"
role="group"
>
<div
class="awsui_grid_14yj0_bdl05_99"
>
<div
class="awsui_grid-column_14yj0_bdl05_143 awsui_colspan-12_14yj0_bdl05_264"
>
<div
class="awsui_restore-pointer-events_14yj0_bdl05_314"
>
<div
class="awsui_row-control_n4qlp_dxsjy_171 awsui_column-layout_vvxn7_1b733_99"
>
<div
class="awsui_grid_14yj0_bdl05_99 awsui_grid_vvxn7_1b733_134 awsui_grid-columns-2_vvxn7_1b733_161 awsui_no-gutters_14yj0_bdl05_138 awsui_grid-breakpoint-default_vvxn7_1b733_152"
>
<div
class="awsui_grid-column_14yj0_bdl05_143 awsui_colspan-12_14yj0_bdl05_264"
>
<div
class="awsui_restore-pointer-events_14yj0_bdl05_314"
>
<div
class="awsui_field_n4qlp_dxsjy_175 awsui_root_14mhv_zqt7u_174"
data-analytics-field-label="[id=\"first-control-id-558-1712660564080-2853-label\"]"
>
<div
class=""
>
<label
class="awsui_label_14mhv_zqt7u_210"
for="first-control-id-558-1712660564080-2853"
id="first-control-id-558-1712660564080-2853-label"
>
Key
</label>
</div>
<div
class="awsui_controls_14mhv_zqt7u_246"
>
<div
class="awsui_grid_14yj0_bdl05_99"
>
<div
class="awsui_grid-column_14yj0_bdl05_143 awsui_colspan-12_14yj0_bdl05_264"
>
<div
class="awsui_restore-pointer-events_14yj0_bdl05_314"
>
<div
class="awsui_control_14mhv_zqt7u_246"
>
<div
class="awsui_root_12hwc_oboi4_5"
>
<div
class="awsui_root_qwoo0_1v6mf_149"
>
<div
|
|
Flashbar component › withAnimations=true › Accessibility › renders the label:
src/flashbar/__tests__/flashbar.test.tsx#L436
expect(received).toHaveTextContent()
received value must be a Node.
Received has value: null
Ignored nodes: comments, script, style
<html>
<head />
<body
class=""
>
<div
class="awsui_announcer_3bgfn_7vh5v_103"
>
Status Error The header The content
</div>
<div
class="awsui_announcer_3bgfn_7vh5v_103"
/>
<div>
<div
class="awsui_flashbar_1q84n_1aw8j_723 awsui_breakpoint-default_1q84n_1aw8j_891"
>
<ul
class="awsui_flash-list_1q84n_1aw8j_301"
>
<li
class="awsui_flash-list-item_1q84n_1aw8j_301"
>
<div
aria-live="off"
class="awsui_flash_1q84n_1aw8j_99 awsui_flash-type-error_1q84n_1aw8j_909 awsui_flash-with-motion_1q84n_1aw8j_99 awsui_flash-refresh_1q84n_1aw8j_798 awsui_entering_1q84n_1aw8j_152 awsui-context-flashbar"
data-analytics-flashbar="error"
data-itemid="1"
role="status"
>
<div
class="awsui_flash-body_1q84n_1aw8j_113"
>
<div
class="awsui_flash-focus-container_1q84n_1aw8j_819"
tabindex="-1"
>
<div
aria-label="Error"
class="awsui_flash-icon_1q84n_1aw8j_139 awsui_flash-text_1q84n_1aw8j_849"
role="img"
>
<span
class="awsui_icon_h11ix_obmua_104 awsui_size-normal-mapped-height_h11ix_obmua_158 awsui_size-normal_h11ix_obmua_154 awsui_variant-normal_h11ix_obmua_230"
>
<svg
aria-hidden="true"
focusable="false"
viewBox="0 0 16 16"
xmlns="http://www.w3.org/2000/svg"
>
<circle
class="stroke-linejoin-round"
cx="8"
cy="8"
r="7"
/>
<path
d="m10.828 5.172-5.656 5.656M10.828 10.828 5.172 5.172"
/>
</svg>
</span>
</div>
<div
class="awsui_flash-message_1q84n_1aw8j_113 awsui_flash-text_1q84n_1aw8j_849"
>
<div
class="awsui_flash-header_1q84n_1aw8j_113"
>
The header
</div>
<div
class="awsui_flash-content_1q84n_1aw8j_114"
>
The content
</div>
</div>
</div>
</div>
</div>
</li>
</ul>
</div>
</div>
</body>
</html>
at __EXTERNAL_MATCHER_TRAP__ (node_modules/expect/build/index.js:346:30)
at Object.throwingMatcher [as toHaveTextContent] (node_modules/expect/build/index.js:347:15)
at src/flashbar/__tests__/flashbar.test.tsx:436:62
at runWithExpensiveErrorDiagnosticsDisabled (node_modules/@testing-library/dom/dist/config.js:52:12)
at checkCallback (node_modules/@testing-library/dom/dist/wait-for.js:141:77)
at checkRealTimersCallback (node_modules/@testing-library/dom/dist/wait-for.js:133:16)
at Timeout.task [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:514:19)
|
|
Flashbar component › withAnimations=false › Accessibility › renders the label:
src/flashbar/__tests__/flashbar.test.tsx#L436
expect(received).toHaveTextContent()
received value must be a Node.
Received has value: null
Ignored nodes: comments, script, style
<html>
<head />
<body
class="awsui-motion-disabled"
>
<div
class="awsui_announcer_3bgfn_7vh5v_103"
>
Error The header The content Status
</div>
<div
class="awsui_announcer_3bgfn_7vh5v_103"
/>
<div>
<div
class="awsui_flashbar_1q84n_1aw8j_723 awsui_breakpoint-default_1q84n_1aw8j_891"
>
<ul
class="awsui_flash-list_1q84n_1aw8j_301"
>
<li
class="awsui_flash-list-item_1q84n_1aw8j_301"
>
<div
aria-live="off"
class="awsui_flash_1q84n_1aw8j_99 awsui_flash-type-error_1q84n_1aw8j_909 awsui-context-flashbar"
data-analytics-flashbar="error"
data-itemid="1"
role="status"
>
<div
class="awsui_flash-body_1q84n_1aw8j_113"
>
<div
class="awsui_flash-focus-container_1q84n_1aw8j_819"
tabindex="-1"
>
<div
aria-label="Error"
class="awsui_flash-icon_1q84n_1aw8j_139 awsui_flash-text_1q84n_1aw8j_849"
role="img"
>
<span
class="awsui_icon_h11ix_obmua_104 awsui_size-normal-mapped-height_h11ix_obmua_158 awsui_size-normal_h11ix_obmua_154 awsui_variant-normal_h11ix_obmua_230"
>
<svg
aria-hidden="true"
focusable="false"
viewBox="0 0 16 16"
xmlns="http://www.w3.org/2000/svg"
>
<circle
class="stroke-linejoin-round"
cx="8"
cy="8"
r="7"
/>
<path
d="m10.828 5.172-5.656 5.656M10.828 10.828 5.172 5.172"
/>
</svg>
</span>
</div>
<div
class="awsui_flash-message_1q84n_1aw8j_113 awsui_flash-text_1q84n_1aw8j_849"
>
<div
class="awsui_flash-header_1q84n_1aw8j_113"
>
The header
</div>
<div
class="awsui_flash-content_1q84n_1aw8j_114"
>
The content
</div>
</div>
</div>
</div>
</div>
</li>
</ul>
</div>
</div>
</body>
</html>
at __EXTERNAL_MATCHER_TRAP__ (node_modules/expect/build/index.js:346:30)
at Object.throwingMatcher [as toHaveTextContent] (node_modules/expect/build/index.js:347:15)
at src/flashbar/__tests__/flashbar.test.tsx:436:62
at runWithExpensiveErrorDiagnosticsDisabled (node_modules/@testing-library/dom/dist/config.js:52:12)
at checkCallback (node_modules/@testing-library/dom/dist/wait-for.js:141:77)
at checkRealTimersCallback (node_modules/@testing-library/dom/dist/wait-for.js:133:16)
at Timeout.task [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:514:19)
|
|
disables all navigation while a step is loading:
src/wizard/__tests__/wizard.test.tsx#L490
expect(received).toHaveTextContent()
received value must be a Node.
Received has value: undefined
at __EXTERNAL_MATCHER_TRAP__ (node_modules/expect/build/index.js:346:30)
at Object.throwingMatcher [as toHaveTextContent] (node_modules/expect/build/index.js:347:15)
at Object.<anonymous> (src/wizard/__tests__/wizard.test.tsx:490:87)
|
|
Attribute Editor › remove button › renders itemRemovedAriaLive on remove button click:
src/attribute-editor/__tests__/attribute-editor.test.tsx#L250
expect(received).toHaveTextContent()
received value must be a Node.
Received has value: undefined
Ignored nodes: comments, script, style
<html>
<head />
<body>
<div
class="awsui_announcer_3bgfn_7vh5v_103"
/>
<div
class="awsui_announcer_3bgfn_7vh5v_103"
/>
<div>
<div
class="awsui_root_n4qlp_dxsjy_125"
>
<div
class="awsui_root_18wu0_zm72j_99 awsui_box_18wu0_zm72j_219 awsui_m-bottom-l_18wu0_zm72j_951 awsui_color-default_18wu0_zm72j_219 awsui_font-size-default_18wu0_zm72j_235 awsui_font-weight-default_18wu0_zm72j_275"
>
<div
class="awsui_row_n4qlp_dxsjy_167 awsui_root_18wu0_zm72j_99 awsui_box_18wu0_zm72j_219 awsui_m-bottom-s_18wu0_zm72j_901 awsui_color-default_18wu0_zm72j_219 awsui_font-size-default_18wu0_zm72j_235 awsui_font-weight-default_18wu0_zm72j_275"
>
<div
aria-labelledby="first-control-id-320-1712660586119-3838-label first-control-id-320-1712660586119-3838"
role="group"
>
<div
class="awsui_grid_14yj0_bdl05_99"
>
<div
class="awsui_grid-column_14yj0_bdl05_143 awsui_colspan-12_14yj0_bdl05_264"
>
<div
class="awsui_restore-pointer-events_14yj0_bdl05_314"
>
<div
class="awsui_row-control_n4qlp_dxsjy_171 awsui_column-layout_vvxn7_1b733_99"
>
<div
class="awsui_grid_14yj0_bdl05_99 awsui_grid_vvxn7_1b733_134 awsui_grid-columns-3_vvxn7_1b733_167 awsui_no-gutters_14yj0_bdl05_138 awsui_grid-breakpoint-default_vvxn7_1b733_152"
>
<div
class="awsui_grid-column_14yj0_bdl05_143 awsui_colspan-12_14yj0_bdl05_264"
>
<div
class="awsui_restore-pointer-events_14yj0_bdl05_314"
>
<div
class="awsui_field_n4qlp_dxsjy_175 awsui_root_14mhv_zqt7u_174"
data-analytics-field-label="[id=\"first-control-id-320-1712660586119-3838-label\"]"
>
<div
class=""
>
<label
class="awsui_label_14mhv_zqt7u_210"
for="first-control-id-320-1712660586119-3838"
id="first-control-id-320-1712660586119-3838-label"
>
Key label
</label>
<span
class="awsui_info_14mhv_zqt7u_224"
>
Key info
</span>
</div>
<div
class="awsui_controls_14mhv_zqt7u_246"
>
<div
class="awsui_grid_14yj0_bdl05_99"
>
<div
class="awsui_grid-column_14yj0_bdl05_143 awsui_colspan-12_14yj0_bdl05_264"
>
<div
class="awsui_restore-pointer-events_14yj0_bdl05_314"
>
<div
class="awsui_control_14mhv_zqt7u_246"
>
k2
</div>
</div>
</div>
|
|
Date range picker calendar › aria labels › add aria-live when date is selected:
src/date-range-picker/calendar/__tests__/calendar.test.tsx#L81
TypeError: Cannot read properties of null (reading 'getElement')
at findLiveAnnouncement (src/date-range-picker/calendar/__tests__/calendar.test.tsx:81:82)
at Object.<anonymous> (src/date-range-picker/calendar/__tests__/calendar.test.tsx:460:14)
|
|
Date range picker calendar › aria labels › renders default range announcement when i18n string is not provided:
src/date-range-picker/calendar/__tests__/calendar.test.tsx#L81
TypeError: Cannot read properties of null (reading 'getElement')
at findLiveAnnouncement (src/date-range-picker/calendar/__tests__/calendar.test.tsx:81:82)
at Object.<anonymous> (src/date-range-picker/calendar/__tests__/calendar.test.tsx:492:14)
|
|
Date range picker › validation › does not display the error message until after the first submit:
src/date-range-picker/__tests__/date-range-picker.test.tsx#L256
expect(received).not.toBe(expected) // Object.is equality
Expected: not null
at Object.<anonymous> (src/date-range-picker/__tests__/date-range-picker.test.tsx:256:110)
|
|
initial state › custom aria-attributes are assigned to plot:
src/internal/components/chart-plot/__tests__/chart-plot.test.tsx#L107
TypeError: Cannot read properties of null (reading 'getElement')
at Object.<anonymous> (src/internal/components/chart-plot/__tests__/chart-plot.test.tsx:107:42)
|
|
build / build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
build / build:
pages/button/alignment.page.tsx#L22
Unexpected 'todo' comment: 'TODO: uncomment when we add...'
|
|
build / build:
pages/form-field/form-field-columns.page.tsx#L18
Unexpected 'todo' comment: 'TODO: Replace this with Select'
|
|
build / build:
pages/utils/permutations-view.tsx#L17
Unexpected 'todo' comment: 'TODO: Pretty-print original JSX,...'
|
|
build / build:
src/__a11y__/to-validate-a11y.ts#L75
Unexpected 'todo' comment: 'TODO: remove polyfill with es2019...'
|
|
build / build:
src/autosuggest/interfaces.ts#L155
Unexpected 'todo' comment: 'TODO: use DropdownOption type same as in...'
|
|
build / build:
src/flashbar/collapsible-flashbar.tsx#L324
JSX element uses aria-live property. Prefer using LiveRegion component instead
|
|
build / build:
src/internal/analytics/__integ__/static-multi-page-create.test.ts#L245
Unexpected 'todo' comment: 'TODO: This is the current order, it...'
|
|
build / build:
src/internal/analytics/__integ__/static-multi-page-create.test.ts#L342
Unexpected 'fixme' comment: 'FIXME: Should be a funnelStepError with...'
|
|
build / build:
src/internal/analytics/__integ__/static-single-page-flow.test.ts#L192
Unexpected 'todo' comment: 'TODO: This is how it is currently. It...'
|
|
build / build:
src/internal/analytics/__integ__/static-single-page-flow.test.ts#L251
Unexpected 'fixme' comment: 'FIXME: Missing funnelStepError?'
|