-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use a centralized announcer to make aria-live announcements #2128
Draft
avinashbot
wants to merge
9
commits into
main
Choose a base branch
from
announcer-prototype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinashbot
force-pushed
the
announcer-prototype
branch
from
April 9, 2024 11:00
bbf01f3
to
443d9e6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
==========================================
- Coverage 96.21% 96.19% -0.03%
==========================================
Files 761 764 +3
Lines 21490 21552 +62
Branches 7359 6973 -386
==========================================
+ Hits 20676 20731 +55
- Misses 761 813 +52
+ Partials 53 8 -45 ☔ View full report in Codecov by Sentry. |
avinashbot
force-pushed
the
announcer-prototype
branch
from
October 18, 2024 09:38
c5423c1
to
b6dd60d
Compare
avinashbot
changed the title
experiment: Centralized announcer prototype
feat: Use a centralized announcer to make aria-live announcements
Oct 18, 2024
avinashbot
force-pushed
the
announcer-prototype
branch
2 times, most recently
from
October 18, 2024 12:34
7c5c3c2
to
28902b6
Compare
avinashbot
force-pushed
the
announcer-prototype
branch
from
October 18, 2024 12:55
28902b6
to
a87d20b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the live region component internally! See the internal docs for motivation and improvements, but the big improvements are the lack of double-text when LiveRegion is used, grouped and debounced updates across multiple local live regions, including custom components in the future.
See: tXwQOO7xEK8T
How has this been tested?
Unit tests and integration tests - most existing tests pass, but some failing ones have been updated to handle the lack of a local live region.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.