Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use a centralized announcer to make aria-live announcements #2128

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

avinashbot
Copy link
Member

@avinashbot avinashbot commented Apr 9, 2024

Description

Introduces the live region component internally! See the internal docs for motivation and improvements, but the big improvements are the lack of double-text when LiveRegion is used, grouped and debounced updates across multiple local live regions, including custom components in the future.

See: tXwQOO7xEK8T

How has this been tested?

Unit tests and integration tests - most existing tests pass, but some failing ones have been updated to handle the lack of a local live region.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 93.80531% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.19%. Comparing base (7693793) to head (264abac).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/internal/components/live-region/controller.ts 88.37% 5 Missing ⚠️
src/button/internal.tsx 75.00% 1 Missing ⚠️
src/internal/components/live-region/internal.tsx 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2128      +/-   ##
==========================================
- Coverage   96.21%   96.19%   -0.03%     
==========================================
  Files         761      764       +3     
  Lines       21490    21552      +62     
  Branches     7359     6973     -386     
==========================================
+ Hits        20676    20731      +55     
- Misses        761      813      +52     
+ Partials       53        8      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avinashbot avinashbot changed the title experiment: Centralized announcer prototype feat: Use a centralized announcer to make aria-live announcements Oct 18, 2024
@avinashbot avinashbot force-pushed the announcer-prototype branch 2 times, most recently from 7c5c3c2 to 28902b6 Compare October 18, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant